Review main Merged

52643[TASK] Remove obsolete htmlarea display hotfix

Andreas Kienast CR +2 V +2 Easy +5 −18 updated 05/02/17, 18:08

Commit message

The display hotfix for the old RTE was required to bypass some
initialization issues. This hotfix is not required anymore and improves
the collapse and scroll performance when having a lot of collapsed
panels in the record list, e.g. if EXT:static_info_tables is installed.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1316

  1. Andreas Kienast uploaded patch set 1 04/27/17, 17:08

  2. TYPO3com voted on patch set 1 V +1 04/27/17, 17:13 Completed build in 05m 17s on Thu, 27 Apr, 07:13 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11053

  3. Wouter Wolters voted on patch set 1 CR +1 04/27/17, 17:49

  4. Henrik Elsner voted on patch set 1 CR +1 04/28/17, 07:37

  5. Benni Mack commented on patch set 1 CR -1 04/28/17, 09:46

    only for master, please. for 8.7 htmlarea is still supported.
  6. Andreas Kienast updated the commit message in patch set 2 04/30/17, 10:16

  7. TYPO3com voted on patch set 2 V +1 04/30/17, 10:22 Completed build in 05m 37s on Sun, 30 Apr, 12:22 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11105

  8. Henrik Elsner voted on patch set 2 CR +1 05/02/17, 07:26

  9. Georg Ringer commented on patch set 2 05/02/17, 08:02

    so how does that look like if the htmlarea ext is installed? or is that nothing we support?
  10. Henrik Elsner voted on patch set 2 V +1 05/02/17, 08:10

  11. Andreas Kienast commented on patch set 2 05/02/17, 08:13

    @Georg: EXT:htmlarea is not supported in TYPO3 v9 (=breaks instantly in FormEngine). Initially I wanted to backport this to 8.7 as I couldn't find any breakings after applying the patch, so I assume that the "original" issue was solved meanwhile. tl;dr: If EXT:htmlarea will be compatible to v9 anytime, it should not break but I can't guarantee this, yet.
  12. Andreas Kienast uploaded patch set 3 05/02/17, 09:43

  13. TYPO3com voted on patch set 3 V +1 05/02/17, 09:50 Completed build in 06m 21s on Tue, 2 May, 11:50 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11124

  14. Wouter Wolters voted on patch set 3 CR +1 V +1 05/02/17, 18:04

  15. Georg Ringer voted on patch set 3 CR +2 V +2 05/02/17, 18:08

  16. Gerrit merged patch set 3 05/02/17, 18:08