Review main Merged

52646[BUGFIX] Load PageTSconfig in localconf for LinkHandler

Benni Mack CR +2 V +2 Normal +35 −33 updated 04/28/17, 09:49

Commit message

The pageTSconfig for LinkHandler is only loaded in ext_tables.php
which means it is only evaluated in the Frontend when a Backend User
is logged in.

However the functionality did work before, if a compiled pageTS was
available in the cache. This could have happened that the pageTS cache
was filled while a BE user was logged in, so it worked (but only in
random cases).

Review

  • Code review CR +2
    • Markus Klein +2
    • Marc Bastian Heinrichs +1
  • Verified V +2
    • Markus Klein +2
    • Marc Bastian Heinrichs +1

Issues 1

Files 2

Review log 911

  1. Benni Mack uploaded patch set 1 04/28/17, 08:50

  2. TYPO3com voted on patch set 1 V +1 04/28/17, 08:55 Completed build in 04m 57s on Fri, 28 Apr, 10:55 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11067

  3. Benni Mack updated the commit message in patch set 2 04/28/17, 08:57

  4. Benni Mack commented on patch set 2 04/28/17, 08:58

    Thanks to MaBa for finding the issue!
  5. Marc Bastian Heinrichs voted on patch set 2 CR +1 V +1 04/28/17, 09:02

  6. Markus Klein commented on patch set 2 CR +1 V +1 04/28/17, 09:02

    Thanks!
  7. Markus Klein voted on patch set 2 CR +2 V +2 04/28/17, 09:02

  8. Gerrit merged patch set 2 04/28/17, 09:02

  9. TYPO3com commented on patch set 2 04/28/17, 09:02 Completed build in 05m 15s on Fri, 28 Apr, 11:02 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11068

  10. Markus Klein commented on patch set 3 04/28/17, 09:03

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 35645e9a2dacdf077d291c4ffe085d686c1a86b5
  11. Marc Bastian Heinrichs commented on patch set 2 04/28/17, 09:49

    Would be nive to have this in 7.6, too.