52648[BUGFIX] Load PageTSconfig in localconf for LinkHandler
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Georg Ringer +1
- Andreas Kienast +1
- Marc Bastian Heinrichs +1
-
Verified V +2
- Stefan Neufeind +2
- Georg Ringer +1
- Marc Bastian Heinrichs +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1214
-
Benni Mack uploaded patch set 1 04/28/17, 09:59
-
Markus Klein commented on patch set 1 CR -1 04/28/17, 10:04
We don't need this in 7.6 for FE!?!? -
TYPO3com voted on patch set 1 V +1 04/28/17, 10:05 Completed build in 05m 34s on Fri, 28 Apr, 12:05 PM Test Summary: 38592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-912
-
Benni Mack commented on patch set 1 04/28/17, 10:06
@maba. can you check if it does work for you in 7.6 with a wrap "if(TYPO3_MODE === BE)" ? -
Marc Bastian Heinrichs commented on patch set 1 04/28/17, 10:27
Yes, it should have the typo3_mode BE condition, too (like before). But I can check, yes. -
Marc Bastian Heinrichs commented on patch set 1 04/28/17, 12:30
Works right inside "if(TYPO3_MODE === BE)" in ext_localconf. And the bug of missing linkhandler tsconfig with added page tsconfig in a localconf with a condition is gone. <INCLUDE_TYPOSCRIPT: source="FILE:EXT:pathToAnyFileWhichCouldBeEmpty.ts" condition="[PIDinRootline = 1]"> -
Benni Mack commented on patch set 2 05/02/17, 04:47
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 05/02/17, 04:52 Completed build in 05m 02s on Tue, 2 May, 06:52 AM Test Summary: 38592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-913
-
Andreas Kienast voted on patch set 2 CR +1 05/02/17, 05:57
-
Georg Ringer voted on patch set 2 CR +1 V +1 05/02/17, 12:27
-
Stefan Neufeind voted on patch set 2 CR +1 V +1 05/08/17, 07:15
-
Marc Bastian Heinrichs voted on patch set 2 CR +1 V +1 05/11/17, 08:29
-
Stefan Neufeind voted on patch set 2 CR +2 V +2 05/11/17, 08:35
-
Gerrit merged patch set 2 05/11/17, 08:35