Review TYPO3_7-6 Merged

52648[BUGFIX] Load PageTSconfig in localconf for LinkHandler

Benni Mack CR +2 V +2 Normal +37 −33 updated 05/11/17, 08:35

Commit message

The pageTSconfig for LinkHandler is only loaded in ext_tables.php
which means it is only evaluated in the Frontend when a Backend User
is logged in.

However the functionality did work before, if a compiled pageTS was
available in the cache. This could have happened that the pageTS cache
was filled while a BE user was logged in, so it worked (but only in
random cases).

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • Marc Bastian Heinrichs +1
  • Verified V +2
    • Stefan Neufeind +2
    • Georg Ringer +1
    • Marc Bastian Heinrichs +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1214

  1. Benni Mack uploaded patch set 1 04/28/17, 09:59

  2. Markus Klein commented on patch set 1 CR -1 04/28/17, 10:04

    We don't need this in 7.6 for FE!?!?
  3. TYPO3com voted on patch set 1 V +1 04/28/17, 10:05 Completed build in 05m 34s on Fri, 28 Apr, 12:05 PM Test Summary: 38592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-912

  4. Benni Mack commented on patch set 1 04/28/17, 10:06

    @maba. can you check if it does work for you in 7.6 with a wrap "if(TYPO3_MODE === BE)" ?
  5. Marc Bastian Heinrichs commented on patch set 1 04/28/17, 10:27

    Yes, it should have the typo3_mode BE condition, too (like before). But I can check, yes.
  6. Marc Bastian Heinrichs commented on patch set 1 04/28/17, 12:30

    Works right inside "if(TYPO3_MODE === BE)" in ext_localconf. And the bug of missing linkhandler tsconfig with added page tsconfig in a localconf with a condition is gone. <INCLUDE_TYPOSCRIPT: source="FILE:EXT:pathToAnyFileWhichCouldBeEmpty.ts" condition="[PIDinRootline = 1]">
  7. Benni Mack commented on patch set 2 05/02/17, 04:47

    Published edit on patch set 1.
  8. TYPO3com voted on patch set 2 V +1 05/02/17, 04:52 Completed build in 05m 02s on Tue, 2 May, 06:52 AM Test Summary: 38592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-913

  9. Andreas Kienast voted on patch set 2 CR +1 05/02/17, 05:57

  10. Georg Ringer voted on patch set 2 CR +1 V +1 05/02/17, 12:27

  11. Stefan Neufeind voted on patch set 2 CR +1 V +1 05/08/17, 07:15

  12. Marc Bastian Heinrichs voted on patch set 2 CR +1 V +1 05/11/17, 08:29

  13. Stefan Neufeind voted on patch set 2 CR +2 V +2 05/11/17, 08:35

  14. Gerrit merged patch set 2 05/11/17, 08:35