Review main Merged

52650[TASK] Use fluid inline notation in HTML attribute values

Simon Schaufelberger CR +2 V +2 Easy +2 −2 updated 05/01/17, 10:25

Commit message

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Sascha Egerer +1
    • Riccardo De Contardi +1
  • Verified V +2
    • Andreas Kienast +2
    • Sascha Egerer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1215

  1. Simon Schaufelberger uploaded patch set 1 04/28/17, 11:03

  2. TYPO3com voted on patch set 1 V +1 04/28/17, 11:08 Completed build in 05m 03s on Fri, 28 Apr, 01:08 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11077

  3. Simon Schaufelberger uploaded patch set 2 04/28/17, 11:14

  4. TYPO3com voted on patch set 2 V +1 04/28/17, 11:19 Completed build in 05m 34s on Fri, 28 Apr, 01:19 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11078

  5. Henrik Elsner voted on patch set 2 CR +1 04/28/17, 11:58

  6. Riccardo De Contardi voted on patch set 2 CR +1 04/28/17, 14:47

  7. Sascha Egerer updated the commit message in patch set 3 04/28/17, 18:47

  8. Sascha Egerer voted on patch set 3 CR +1 04/28/17, 18:47

  9. TYPO3com voted on patch set 3 V +1 04/28/17, 18:52 Completed build in 05m 14s on Fri, 28 Apr, 08:52 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11089

  10. Riccardo De Contardi voted on patch set 3 CR +1 04/28/17, 18:54

  11. Sascha Egerer voted on patch set 3 V +1 04/29/17, 11:48

  12. Andreas Kienast voted on patch set 3 CR +2 V +2 05/01/17, 09:55

  13. Gerrit merged patch set 3 05/01/17, 09:55

  14. Simon Schaufelberger commented on patch set 4 05/01/17, 10:04

    Thank you. Should I create a backport for other TYPO3 versions as well?
  15. Andreas Kienast commented on patch set 4 05/01/17, 10:25

    I think backports are not necessary here.