Review main Merged

52666[FOLLOWUP][BUGFIX] LinkService must handle old ?id=xyz links

Christer V CR +2 V +2 Easy +1 −1 updated 05/02/17, 08:22

Commit message

Changed so ../index.php?id=xyz links are also matched.

Review

  • Code review CR +2
    • Markus Klein +2
    • Andreas Kienast +1
    • Christer V +1
    • Anders Kostending +1
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Christer V uploaded patch set 1 05/01/17, 07:53

  2. TYPO3com voted on patch set 1 V +1 05/01/17, 08:01 Completed build in 08m 04s on Mon, 1 May, 10:01 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11108

  3. Markus Klein updated the commit message in patch set 2 05/01/17, 10:08

  4. Markus Klein commented on patch set 2 CR -1 05/01/17, 10:08

    LegacyLinkNotationConverter.php:88

    Declare this a non-capturing group the no code change is needed
  5. Markus Klein commented on patch set 3 05/01/17, 10:09

    Published edit on patch set 2.
  6. Markus Klein voted on patch set 3 CR +1 05/01/17, 10:09

  7. TYPO3com voted on patch set 2 V +1 05/01/17, 10:13 Completed build in 05m 18s on Mon, 1 May, 12:13 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11111

  8. TYPO3com voted on patch set 3 V +1 05/01/17, 10:16 Completed build in 07m 43s on Mon, 1 May, 12:16 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11112

  9. Christer V voted on patch set 3 CR +1 05/01/17, 10:33

  10. Andreas Kienast voted on patch set 3 CR +1 05/01/17, 10:35

  11. Anders Kostending voted on patch set 3 CR +1 05/02/17, 06:36

  12. Markus Klein commented on patch set 3 CR +2 V +2 05/02/17, 08:22

    I doubt we get reviews by testing here. I take the freedom to merge.
  13. Gerrit merged patch set 3 05/02/17, 08:22

  14. Markus Klein commented on patch set 4 05/02/17, 08:22

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit cbeef7d663b4fea5383e5af640ae379caf25355f