Review main Merged

52670[BUGFIX] Add missing SQL index for EM repository update

Claus Due CR +2 V +2 Easy +1 −1 updated 09/07/17, 07:51

Commit message

Due to the large number of extensions, the query that
checks if an extension exists needs an index that
covers all of the columns used for joining/clauses.

Review

  • Code review CR +2
    • Jan Helke +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Michael Oehlhof +1
    • Christer V +1
  • Verified V +2
    • Jan Helke +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1820

  1. Claus Due uploaded patch set 1 05/01/17, 15:30

  2. TYPO3com voted on patch set 1 V +1 05/01/17, 15:35 Completed build in 05m 12s on Mon, 1 May, 05:35 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11115

  3. Jan Kornblum voted on patch set 1 CR +1 V +1 05/01/17, 20:31

  4. Christer V voted on patch set 1 CR +1 05/02/17, 06:33

  5. Thomas Hohn commented on patch set 1 CR -1 05/02/17, 06:50

    ext_tables.sql:46

    Please extend KEY index_versionrepo (integer_version,repository) with extension_key instead. INDEX(integer_version,repository,extension_key) can find anything that INDEX(integer_version,repository) could find
  6. Christian Weiske uploaded patch set 2 05/05/17, 10:02

  7. Christian Weiske commented on patch set 1 05/05/17, 10:04

    ext_tables.sql:46 Reply

    Done
  8. TYPO3com voted on patch set 2 V +1 05/05/17, 10:07 Completed build in 05m 55s on Fri, 5 May, 12:07 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11216

  9. Christer V voted on patch set 2 CR +1 05/05/17, 10:49

  10. Andreas Kienast voted on patch set 2 CR +1 V +1 05/05/17, 11:25

  11. Michael Oehlhof voted on patch set 2 CR +1 05/05/17, 11:50

  12. Tymoteusz Motylewski commented on patch set 2 05/05/17, 12:47

    How did you guys tested it? Here install tool is not showing a change to index in the database analyzer. Did you manually remove the index before applying the patch?
  13. Christian Weiske commented on patch set 2 05/05/17, 13:22

    > How did you guys tested it? Here install tool is not showing a > change to index in the database analyzer. Did you manually remove > the index before applying the patch? The install tool here did show the change and applied it flawlessly. I used cli_dispatch.phpsh to run the extension-list-update scheduler task before and after the task. Before it took > 5min, after it takes ~12s.
  14. Oliver Klee voted on patch set 2 CR +1 05/05/17, 13:23

  15. Jan Helke voted on patch set 2 CR +1 V +1 05/05/17, 14:37

  16. Jan Helke commented on patch set 2 05/05/17, 14:39

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 5cf0167fca431ec4a5e4f6e2b6de24f9c405ddd8
  17. Jan Helke voted on patch set 2 CR +2 V +2 05/05/17, 15:52

  18. Gerrit merged patch set 2 05/05/17, 15:52

  19. Christian Weiske commented on patch set 3 05/10/17, 09:29

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 76186f1d4e7593087348cc452058ad0d6c6edc5c
  20. Stephan Großberndt commented on patch set 3 09/07/17, 07:51