Review main Merged

52683[TASK] Replace outdated nowrap attribute

Henrik Elsner CR +2 V +2 Normal +115 −111 updated 05/11/17, 12:35

Commit message

The outdated nowrap attribute for table tags
is replaced by a class addition, bringing
the functional stylings

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 17

Review log 2130

Show 45 earlier messages
  1. Henrik Elsner uploaded patch set 1 05/02/17, 14:19

  2. TYPO3com voted on patch set 1 V +1 05/02/17, 14:24 Completed build in 04m 59s on Tue, 2 May, 04:24 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11133

  3. Riccardo De Contardi commented on patch set 1 05/02/17, 14:36

    also EXT:tstemplate\Resources\Private\Templates\PageZero.html ?
  4. Henrik Elsner uploaded patch set 2 05/02/17, 15:01

  5. Henrik Elsner commented on patch set 2 05/02/17, 15:01

    Yep got that already - thanks tho
  1. TYPO3com voted on patch set 2 V +1 05/02/17, 15:06 Completed build in 05m 04s on Tue, 2 May, 05:06 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11135

  2. Riccardo De Contardi commented on patch set 2 CR -1 05/02/17, 15:31

    AbstractRecordList.php:237

    you are adding the class attribute twice...

    AbstractRecordList.php:272

    also here....

    AbstractRecordList.php:295

    also here...
  3. Henrik Elsner uploaded patch set 3 05/03/17, 07:42

  4. TYPO3com voted on patch set 3 V -1 05/03/17, 07:42 Completed build in 05s on Wed, 3 May, 09:42 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11165

  5. Henrik Elsner uploaded patch set 4 05/03/17, 08:56

  6. TYPO3com voted on patch set 4 V -1 05/03/17, 08:56 Completed build in 05s on Wed, 3 May, 10:56 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11167

  7. Henrik Elsner uploaded patch set 5 05/03/17, 09:40

  8. TYPO3com voted on patch set 5 V -1 05/03/17, 09:45 Completed build in 05m 42s on Wed, 3 May, 11:45 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11168

  9. Henrik Elsner uploaded patch set 6 05/03/17, 10:58

  10. TYPO3com voted on patch set 6 V +1 05/03/17, 11:03 Completed build in 05m 18s on Wed, 3 May, 01:03 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11170

  11. Oliver Klee commented on patch set 6 05/03/17, 12:07

    TabContent.html:5

    Here, the nowrap class is missing.

    Page.html:9

    These changes are more than just using the nowrap class.
  12. Henrik Elsner commented on patch set 6 05/03/17, 12:51

    TabContent.html:5 Reply

    Thanks :)

    Page.html:9 Reply

    Those acutally should be the rebase changes - strange there in here, but thanks for the notification.
  13. Henrik Elsner uploaded patch set 7 05/03/17, 12:58

  14. TYPO3com voted on patch set 7 V +1 05/03/17, 13:04 Completed build in 05m 45s on Wed, 3 May, 03:04 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11172

  15. Henrik Elsner uploaded patch set 8 05/03/17, 13:06

  16. TYPO3com voted on patch set 8 V +1 05/03/17, 13:12 Completed build in 05m 42s on Wed, 3 May, 03:12 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11173

  17. Oliver Klee voted on patch set 8 CR +1 05/03/17, 13:16

  18. Henrik Elsner uploaded patch set 9 05/03/17, 13:25

  19. TYPO3com voted on patch set 9 V +1 05/03/17, 13:31 Completed build in 05m 22s on Wed, 3 May, 03:31 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11174

  20. Oliver Klee voted on patch set 9 CR +1 05/03/17, 13:40

  21. Benni Mack voted on patch set 9 CR +1 V +1 05/10/17, 05:16

  22. Anja Leichsenring voted on patch set 9 CR +1 V +1 05/11/17, 12:33

  23. Benni Mack voted on patch set 9 CR +2 V +2 05/11/17, 12:34

  24. Gerrit merged patch set 9 05/11/17, 12:34

  25. Benni Mack commented on patch set 10 05/11/17, 12:35

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 941d0b4886f518fd3324aa272fcb00801ab6e4c3