Review main Merged

52692[BUGFIX] Let ElementInfo Template take care of proper title crop

Mathias Brodala CR +2 V +2 Easy +14 −12 updated 05/12/17, 13:19

Commit message

If the title is too long, it gets cropped. Then, the link title must
contain the whole string in order to provide a proper tooltip.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Elmar Hinz +1
    • Anja Leichsenring +1
    • Mathias Brodala +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 4356

Show 2331 earlier messages
  1. Mathias Brodala uploaded patch set 1 05/03/17, 07:32

  2. TYPO3com voted on patch set 1 V +1 05/03/17, 07:37 Completed build in 05m 29s on Wed, 3 May, 09:37 AM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11164

  3. Henrik Elsner voted on patch set 1 CR +1 05/03/17, 15:06

  4. Elmar Hinz commented on patch set 1 05/11/17, 11:33

    What about ElementInformationController::makeRef()? See bug tracker.
  5. Anja Leichsenring commented on patch set 1 CR +1 V +1 05/11/17, 11:44

    this IS makeRef(), getPageTitle() was the reference used to describe the desired behaviour.
  6. Christian Kuhn voted on patch set 1 CR -1 05/11/17, 12:12

  7. Christian Kuhn commented on patch set 1 05/11/17, 12:25

    ElementInformationController.php:588

    I would prefer to not use the strip_tags() here. Instead, it should be ok to give getRecordTitle($table, $record, false, false) (both last arguments false) - this way getRecordTitle does: no fallback for empty title, no cropping, no htmlspecialchars. Then, we can move that to the fluid template and to the cropping and fallback handling over there. That would be much cleaner than the strip_tags() solution. Would you like to take care?
  8. Anja Leichsenring commented on patch set 1 CR -1 05/11/17, 13:11

    I will rework according Christians proposal.
  9. Anja Leichsenring uploaded patch set 2 05/11/17, 13:16

  10. Anja Leichsenring voted on patch set 2 CR +1 V +1 05/11/17, 13:16

  11. Jan Helke voted on patch set 2 CR +1 V +1 05/11/17, 13:17

  12. TYPO3com voted on patch set 2 V +1 05/11/17, 13:25 Completed build in 09m 33s on Thu, 11 May, 03:25 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11401

  13. Christian Kuhn voted on patch set 2 CR -1 05/11/17, 13:27

  14. Jan Helke voted on patch set 2 CR 0 V 0 05/11/17, 13:29

  15. Christian Kuhn commented on patch set 2 05/11/17, 13:35

    first, only half of my suggestion was done: fluid still should crop a bit, probably by assigning be_user->uc['titleLen'] to fluid and acting upon (including fallback if user has no titleLen set). also, we probably need the [no title'] fallback that in fluid. aaand, there are two tables: "reference from" and "reference to" - both need similar fixes.
  16. Anja Leichsenring commented on patch set 2 CR -1 05/11/17, 13:38

    sigh
  17. Anja Leichsenring uploaded patch set 3 05/11/17, 14:19

  18. Anja Leichsenring updated the commit message in patch set 4 05/11/17, 14:21

  19. Anja Leichsenring uploaded patch set 5 05/11/17, 14:23

  20. Anja Leichsenring uploaded patch set 6 05/11/17, 14:24

  21. TYPO3com voted on patch set 3 V -1 05/11/17, 14:25 Completed build in 05m 45s on Thu, 11 May, 04:25 PM Test Summary: 1 of 55917 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11415

  22. Mathias Brodala commented on patch set 6 05/11/17, 14:26

    ElementInformationController.php:240

    This can be removed I guess.
  23. TYPO3com voted on patch set 4 V +1 05/11/17, 14:27 Completed build in 06m 16s on Thu, 11 May, 04:27 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11416

  24. Anja Leichsenring uploaded patch set 7 05/11/17, 14:29

  25. TYPO3com voted on patch set 5 V +1 05/11/17, 14:30 Completed build in 06m 32s on Thu, 11 May, 04:30 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11417

  26. Riccardo De Contardi voted on patch set 7 V +1 05/11/17, 14:31

  27. TYPO3com voted on patch set 3 V +1 05/11/17, 14:31 Completed build in 18m 15s on Thu, 11 May, 04:31 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11415

  28. Mathias Brodala voted on patch set 7 CR +1 V +1 05/11/17, 14:33

  29. TYPO3com voted on patch set 6 V +1 05/11/17, 14:33 Completed build in 08m 57s on Thu, 11 May, 04:33 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11418

  30. Elmar Hinz commented on patch set 7 05/11/17, 14:34

    Let me turn around my question: What about getPageTitle()? Is ist right to apply strict_tags in one method and wrong in the other?
  31. TYPO3com voted on patch set 7 V +1 05/11/17, 14:36 Completed build in 06m 33s on Thu, 11 May, 04:36 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11420

  1. Anja Leichsenring commented on patch set 7 CR -1 05/11/17, 14:48

    I forgot the [No Title]
  2. Anja Leichsenring uploaded patch set 8 05/11/17, 14:55

  3. Anja Leichsenring voted on patch set 8 CR +1 V +1 05/11/17, 14:59

  4. TYPO3com voted on patch set 8 V +1 05/11/17, 15:01 Completed build in 05m 09s on Thu, 11 May, 05:01 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11424

  5. Anja Leichsenring voted on patch set 8 CR -1 V 0 05/11/17, 15:06

  6. Christian Kuhn commented on patch set 8 05/11/17, 15:07

    ElementInformationController.php:266

    can't we handle 'title' now identical as the other cases, so we could get rid of that strip_tags, too?

    ElementInformation.html:133

    good to change the a href to f:link.page!
  7. Anja Leichsenring commented on patch set 8 05/11/17, 15:11

    currently on it . Completely confused -.-
  8. Claus Due commented on patch set 8 CR -1 05/11/17, 15:13

    nit-picks only

    ElementInformation.html:3

    nit-pick: would add space here after the colon.

    ElementInformation.html:133

    Would add space.

    ElementInformation.html:133 Reply

    Looks like the same can be done for the other links.

    ElementInformation.html:161

    would add space
  9. Anja Leichsenring uploaded patch set 9 05/11/17, 15:13

  10. Anja Leichsenring uploaded patch set 10 05/11/17, 15:17

  11. TYPO3com voted on patch set 10 V +1 05/11/17, 15:23 Completed build in 06m 18s on Thu, 11 May, 05:23 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11427

  12. Riccardo De Contardi voted on patch set 10 V +1 05/11/17, 15:37

  13. TYPO3com voted on patch set 9 V -1 05/11/17, 15:39 Completed build in 25m 33s on Thu, 11 May, 05:39 PM Test Summary: 1 of 55917 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11425

  14. TYPO3com voted on patch set 9 V +1 05/11/17, 15:59 Completed build in 1h 10m 59s on Thu, 11 May, 05:59 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11425

  15. Mathias Brodala voted on patch set 10 CR +1 05/12/17, 12:38

  16. Elmar Hinz voted on patch set 10 CR +1 05/12/17, 12:41

  17. Mathias Brodala voted on patch set 10 V +1 05/12/17, 12:41

  18. Anja Leichsenring commented on patch set 11 05/12/17, 12:46

    Published edit on patch set 10.
  19. Mathias Brodala voted on patch set 11 CR +1 V +1 05/12/17, 12:47

  20. Elmar Hinz voted on patch set 11 CR +1 05/12/17, 12:52

  21. TYPO3com voted on patch set 11 V +1 05/12/17, 12:52 Completed build in 05m 50s on Fri, 12 May, 02:52 PM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11460

  22. Anja Leichsenring commented on patch set 11 CR +1 V +1 05/12/17, 13:09

    Christian said I must vote, too ;)
  23. Christian Kuhn voted on patch set 11 CR +2 V +2 05/12/17, 13:19

  24. Gerrit merged patch set 11 05/12/17, 13:19

  25. Christian Kuhn commented on patch set 12 05/12/17, 13:19

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit fff30b71a6adf5c9f580b6ad49f2e36a1545b7dc