52696[!!!][TASK] Drop dedicated edit view in EXT:tstemplate
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Jan Helke +1
-
Verified V +2
- Christian Kuhn +2
- Jan Helke +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/master/Breaking-81171-EditAbilityOfTypoScriptTemplateInEXTtstemplateRemoved.rst3new+47 −0
- typo3/sysext/t3editor/Classes/Hook/TypoScriptTemplateInfoHook.phpdeleted+0 −149
- typo3/sysext/t3editor/ext_localconf.php+0 −3
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateInformationModuleFunctionController.php+17 −145
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php2+9 −54
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_info.xlf+0 −3
- typo3/sysext/tstemplate/Resources/Private/Templates/InformationModule.html+0 −23
Review log 1826
Show 1 earlier messages
-
Andreas Kienast uploaded patch set 1 05/03/17, 18:19
-
Andreas Kienast uploaded patch set 2 05/03/17, 18:20
-
TYPO3com voted on patch set 1 V -1 05/03/17, 18:26 Completed build in 07m 02s on Wed, 3 May, 08:26 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11182
-
TYPO3com voted on patch set 2 V -1 05/03/17, 18:27 Completed build in 06m 40s on Wed, 3 May, 08:27 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11183
-
Andreas Kienast uploaded patch set 3 05/10/17, 06:48
-
Andreas Kienast uploaded patch set 4 05/10/17, 06:51
-
TYPO3com voted on patch set 3 V -1 05/10/17, 06:54 Completed build in 05m 52s on Wed, 10 May, 08:54 AM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11331
-
TYPO3com voted on patch set 4 V +1 05/10/17, 06:57 Completed build in 05m 47s on Wed, 10 May, 08:57 AM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11332
-
Oliver Klee commented on patch set 4 05/10/17, 08:46
-
Andreas Kienast commented on patch set 4 05/10/17, 08:54
TypoScriptTemplateModuleController.php:302ReplyBecause PhpStorm nags about it as it was wrong all the time and I touched the method anyway... -
Andreas Kienast uploaded patch set 5 05/10/17, 08:57
-
TYPO3com voted on patch set 5 V +1 05/10/17, 09:03 Completed build in 05m 02s on Wed, 10 May, 11:03 AM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11333
-
Andreas Kienast uploaded patch set 6 05/16/17, 06:26
-
TYPO3com voted on patch set 6 V +1 05/16/17, 06:32 Completed build in 05m 17s on Tue, 16 May, 08:32 AM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11508
-
Markus Klein commented on patch set 6 05/16/17, 07:18
Breaking-81171-EditAbilityOfTypoScriptTemplateInEXTtstemplateRemoved.rst:20whichBreaking-81171-EditAbilityOfTypoScriptTemplateInEXTtstemplateRemoved.rst:30followingBreaking-81171-EditAbilityOfTypoScriptTemplateInEXTtstemplateRemoved.rst:32It depends on how your dev-env works, but this was very useful, as this this saves you from jumping around in the files. (today we have all those file in the IDE anyway, so not much trouble for me personally, but I would ask around, who will miss this) -
Andreas Kienast commented on patch set 7 05/16/17, 07:24
Published edit on patch set 6. -
TYPO3com voted on patch set 7 V +1 05/16/17, 07:29 Completed build in 05m 01s on Tue, 16 May, 09:29 AM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11510
-
Sebastian Fischer voted on patch set 7 CR +1 05/18/17, 10:20
-
Christian Kuhn commented on patch set 7 CR -1 05/18/17, 11:33
on it. -
Christian Kuhn uploaded patch set 8 05/18/17, 11:41
-
Christian Kuhn commented on patch set 7 CR 0 05/18/17, 11:41
minor rewordings -
Jan Helke voted on patch set 8 CR +1 V +1 05/18/17, 11:46
-
Christian Kuhn voted on patch set 8 CR +1 V +1 05/18/17, 11:46
-
TYPO3com voted on patch set 8 V +1 05/18/17, 11:47 Completed build in 06m 33s on Thu, 18 May, 01:47 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11570
-
Christian Kuhn voted on patch set 8 CR +2 V +2 05/18/17, 11:54
-
Gerrit merged patch set 8 05/18/17, 11:54
TypoScriptTemplateModuleController.php:302