Review main Merged Breaking

52696[!!!][TASK] Drop dedicated edit view in EXT:tstemplate

Andreas Kienast CR +2 V +2 Hard +73 −377 updated 05/18/17, 11:54

Commit message

Triggering ext:t3editor out-of-bound of FormEngine is pretty tricky and
blocks further development of t3editor. To streamline this, the
current implementation of t3editor within ext:tstemplate is revamped
and now uses FormEngine directly to edit "constants" and "setup" of
template records.
Some hooks are now obsolete and dropped along the way.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1826

Show 1 earlier messages
  1. Andreas Kienast uploaded patch set 1 05/03/17, 18:19

  1. Andreas Kienast uploaded patch set 2 05/03/17, 18:20

  2. TYPO3com voted on patch set 1 V -1 05/03/17, 18:26 Completed build in 07m 02s on Wed, 3 May, 08:26 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11182

  3. TYPO3com voted on patch set 2 V -1 05/03/17, 18:27 Completed build in 06m 40s on Wed, 3 May, 08:27 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11183

  4. Andreas Kienast uploaded patch set 3 05/10/17, 06:48

  5. Andreas Kienast uploaded patch set 4 05/10/17, 06:51

  6. TYPO3com voted on patch set 3 V -1 05/10/17, 06:54 Completed build in 05m 52s on Wed, 10 May, 08:54 AM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11331

  7. TYPO3com voted on patch set 4 V +1 05/10/17, 06:57 Completed build in 05m 47s on Wed, 10 May, 08:57 AM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11332

  8. Oliver Klee commented on patch set 4 05/10/17, 08:46

    TypoScriptTemplateModuleController.php:302

    Why this change? It does not seem related.
  9. Andreas Kienast commented on patch set 4 05/10/17, 08:54

    TypoScriptTemplateModuleController.php:302 Reply

    Because PhpStorm nags about it as it was wrong all the time and I touched the method anyway...
  10. Andreas Kienast uploaded patch set 5 05/10/17, 08:57

  11. TYPO3com voted on patch set 5 V +1 05/10/17, 09:03 Completed build in 05m 02s on Wed, 10 May, 11:03 AM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11333

  12. Andreas Kienast uploaded patch set 6 05/16/17, 06:26

  13. TYPO3com voted on patch set 6 V +1 05/16/17, 06:32 Completed build in 05m 17s on Tue, 16 May, 08:32 AM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11508

  14. Markus Klein commented on patch set 6 05/16/17, 07:18

    Breaking-81171-EditAbilityOfTypoScriptTemplateInEXTtstemplateRemoved.rst:20

    which

    Breaking-81171-EditAbilityOfTypoScriptTemplateInEXTtstemplateRemoved.rst:30

    following

    Breaking-81171-EditAbilityOfTypoScriptTemplateInEXTtstemplateRemoved.rst:32

    It depends on how your dev-env works, but this was very useful, as this this saves you from jumping around in the files. (today we have all those file in the IDE anyway, so not much trouble for me personally, but I would ask around, who will miss this)
  15. Andreas Kienast commented on patch set 7 05/16/17, 07:24

    Published edit on patch set 6.
  16. TYPO3com voted on patch set 7 V +1 05/16/17, 07:29 Completed build in 05m 01s on Tue, 16 May, 09:29 AM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11510

  17. Sebastian Fischer voted on patch set 7 CR +1 05/18/17, 10:20

  18. Christian Kuhn commented on patch set 7 CR -1 05/18/17, 11:33

    on it.
  19. Christian Kuhn uploaded patch set 8 05/18/17, 11:41

  20. Christian Kuhn commented on patch set 7 CR 0 05/18/17, 11:41

    minor rewordings
  21. Jan Helke voted on patch set 8 CR +1 V +1 05/18/17, 11:46

  22. Christian Kuhn voted on patch set 8 CR +1 V +1 05/18/17, 11:46

  23. TYPO3com voted on patch set 8 V +1 05/18/17, 11:47 Completed build in 06m 33s on Thu, 18 May, 01:47 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11570

  24. Christian Kuhn voted on patch set 8 CR +2 V +2 05/18/17, 11:54

  25. Gerrit merged patch set 8 05/18/17, 11:54