52697[BUGFIX] Do not render broken <img> tag if processed file is not an image
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 710
-
Andreas Kienast uploaded patch set 1 05/04/17, 08:59
-
TYPO3com voted on patch set 1 V -1 05/04/17, 09:05 Completed build in 05m 19s on Thu, 4 May, 11:05 AM Test Summary: 12 of 55785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11187
-
Andreas Kienast uploaded patch set 2 05/04/17, 10:03
-
TYPO3com voted on patch set 2 V -1 05/04/17, 10:13 Completed build in 09m 32s on Thu, 4 May, 12:13 PM Test Summary: 55718 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11189
-
TYPO3com voted on patch set 2 V +1 05/04/17, 10:14 Completed build in 20m 16s on Thu, 4 May, 12:14 PM Test Summary: 55788 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11189
-
Frans Saris commented on patch set 2 05/04/17, 11:01
Not sure if this makes sense. Are there more checks like this in the core? -
Elmar Hinz commented on patch set 2 05/11/17, 11:00
A missing image tag could heavily damage the CSS layout. I think a placeholder could be returned. What kind of placeholder? Ideas: - Span with a special class. The size info is missing then. - Image tag with empty URL. The browser decides how to display this. - Image tag linking a transparent pixel or a configurable placeholder image. -
Georg Ringer commented on patch set 2 05/11/17, 12:19
ImageViewHelper.php:145IMO strtolower should be used, otherwise a JPG won't be recognized? -
Claus Due commented on patch set 2 CR -1 05/22/17, 18:54
ImageViewHelper.php:145ReplyPlease throw a ViewHelper Exception here with a message about the unsupported format. Rendering should not be silently suppressed - if you wish to avoid rendering these files you should have a condition further up in the hierarchy to prevent calling this ViewHelper in the first place. -
Andreas Kienast abandoned the change 07/11/17, 10:49