Review main Merged

52701[BUGFIX] EXT:form - catch exceptions within page module and form engine

Ralf Zimmermann CR +2 V +2 Normal +186 −36 updated 09/07/17, 09:40

Commit message

* Show messages within page module and form engine if the backend user
  does not have access to the selected form definition.
* Show flash messages within page module and form engine if the
  ext:form configuration is invalid.

Review

  • Code review CR +2
    • Frans Saris +2
    • Daniel Gohlke +1
    • Björn Jacob +1
  • Verified V +2
    • Frans Saris +2
    • Björn Jacob +1

Issues 2

Files 4

Review log 1520

  1. Ralf Zimmermann uploaded patch set 1 05/04/17, 10:58

  2. TYPO3com voted on patch set 1 V -1 05/04/17, 11:21 Completed build in 22m 49s on Thu, 4 May, 01:21 PM Test Summary: 1 of 55785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11191

  3. Jan Helke voted on patch set 1 CR +1 V +1 05/04/17, 12:49

  4. TYPO3com voted on patch set 1 V +1 05/04/17, 12:51 Completed build in 2h 15m 30s on Thu, 4 May, 02:51 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11191

  5. Henrik Elsner commented on patch set 1 05/04/17, 13:51

    Definitely needs to be patched for 8.7
  6. Henrik Elsner commented on patch set 1 CR -1 05/05/17, 11:52

    Tested on v8 and master - works so far. Small issue: if the user is not allowed to read the file and the file does not exist (so both issues) at the same time - the flash message is "no read access". imho we should change the message and prefer the "no file exists" error case
  7. Frans Saris commented on patch set 1 CR +1 05/13/17, 06:07

    I'm fine with the order of checks first the no read and then the file thus not exist
  8. Ralf Zimmermann uploaded patch set 2 06/30/17, 06:03

  9. TYPO3com voted on patch set 2 V -1 06/30/17, 06:03 Completed build in 09s on Fri, 30 Jun, 08:03 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12903

  10. Ralf Zimmermann uploaded patch set 3 06/30/17, 06:04

  11. TYPO3com voted on patch set 3 V +1 06/30/17, 06:14 Completed build in 09m 56s on Fri, 30 Jun, 08:14 AM Test Summary: 56751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12904

  12. Frans Saris voted on patch set 3 CR +1 V +1 07/14/17, 21:42

  13. Björn Jacob voted on patch set 3 CR +1 V +1 09/07/17, 09:22

  14. Björn Jacob updated the commit message in patch set 4 09/07/17, 09:23

  15. Björn Jacob voted on patch set 4 CR +1 V +1 09/07/17, 09:23

  16. Frans Saris voted on patch set 4 CR +1 V +1 09/07/17, 09:35

  17. Daniel Gohlke voted on patch set 4 CR +1 09/07/17, 09:36

  18. Frans Saris voted on patch set 4 CR +2 V +2 09/07/17, 09:37

  19. Gerrit merged patch set 4 09/07/17, 09:37

  20. TYPO3com commented on patch set 4 09/07/17, 09:40 Completed build in 16m 32s on Thu, 7 Sep, 11:40 AM Test Summary: 58133 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14284