Review main Merged

52704[BUGFIX] Avoid exceptions during indexing with indexed_search

Georg Ringer CR +2 V +2 Easy +3 −1 updated 05/04/17, 12:47

Commit message

The exception "you need to add at least one set of values before
generating the SQL" occurs if the bulkInsert is triggered with
empty values. A check must be done before trying the query.

Review

  • Code review CR +2
    • Markus Klein +2
    • Josef Glatz +1
  • Verified V +2
    • Markus Klein +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Georg Ringer uploaded patch set 1 05/04/17, 12:31

  2. Josef Glatz voted on patch set 1 CR +1 V +1 05/04/17, 12:32

  3. TYPO3com voted on patch set 1 V +1 05/04/17, 12:40 Completed build in 08m 22s on Thu, 4 May, 02:40 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11195

  4. Markus Klein voted on patch set 1 CR +2 V +2 05/04/17, 12:47

  5. Gerrit merged patch set 1 05/04/17, 12:47

  6. Markus Klein commented on patch set 2 05/04/17, 12:47

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 10cb55a3beba57dc1e3b1b5674893935e11104bc