Review main Merged

52736[TASK] Improve BE description of mount point overlay

Elmar Hinz CR +2 V +2 Easy +5 −5 updated 05/10/17, 14:02

Commit message

Give a more precise description of the mount point overlay behaviour:

- Update labels of the page tree.
- Update lables of the page form.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Henrik Elsner +1
  • Verified V +2
    • Christian Kuhn +2
    • Henrik Elsner +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1723

  1. Elmar Hinz uploaded patch set 1 05/07/17, 17:54

  2. TYPO3com voted on patch set 1 V +1 05/07/17, 17:59 Completed build in 05m 06s on Sun, 7 May, 07:59 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11258

  3. Elmar Hinz uploaded patch set 2 05/07/17, 18:19

  4. TYPO3com voted on patch set 2 V +1 05/07/17, 18:24 Completed build in 05m 02s on Sun, 7 May, 08:24 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11259

  5. Elmar Hinz updated the commit message in patch set 3 05/07/17, 19:19

  6. TYPO3com voted on patch set 3 V +1 05/07/17, 19:24 Completed build in 05m 27s on Sun, 7 May, 09:24 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11260

  7. Henrik Elsner commented on patch set 3 05/08/17, 08:45

    locallang_tca.xlf:319

    I personally don't like the term and the question mark. I would prefer something like "Display option for Mount Point" for example.
  8. Elmar Hinz commented on patch set 3 05/08/17, 08:53

    Henrik: Feel free to improve the wording. :) I just wanted to open the process of reviewing the wording, as the current version confused me.
  9. Elmar Hinz uploaded patch set 4 05/08/17, 10:09

  10. Henrik Elsner commented on patch set 4 CR +1 V +1 05/08/17, 10:10

    Sorry - kinda forgot.. but i prefer that now.
  11. TYPO3com voted on patch set 4 V +1 05/08/17, 10:14 Completed build in 05m 14s on Mon, 8 May, 12:14 PM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11263

  12. Riccardo De Contardi voted on patch set 4 V +1 05/08/17, 20:33

  13. Thomas Hohn voted on patch set 4 CR +1 05/09/17, 08:31

  14. Benni Mack commented on patch set 4 05/10/17, 06:09

    Very nice. could we get rid of the "." in the labels? we don't use that anywhere else except for full sentences. (also in the commit message headline)
  15. Elmar Hinz uploaded patch set 5 05/10/17, 09:17

  16. TYPO3com voted on patch set 5 V +1 05/10/17, 09:23 Completed build in 05m 05s on Wed, 10 May, 11:23 AM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11334

  17. Henrik Elsner voted on patch set 5 CR +1 V +1 05/10/17, 09:24

  18. Tymoteusz Motylewski updated the commit message in patch set 6 05/10/17, 11:22

  19. TYPO3com voted on patch set 6 V +1 05/10/17, 11:28 Completed build in 05m 32s on Wed, 10 May, 01:28 PM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11335

  20. Henrik Elsner voted on patch set 6 CR +1 V +1 05/10/17, 11:42

  21. Christian Kuhn voted on patch set 6 CR +2 V +2 05/10/17, 14:02

  22. Gerrit merged patch set 6 05/10/17, 14:02

  23. Christian Kuhn commented on patch set 7 05/10/17, 14:02

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 73e58096113b5f04ca896b6597960d96cbe08511