Review main Abandoned

52738[TASK] Deprecate usage of custom salts

Christian Futterlieb CR 0 V 0 Easy +49 −1 updated 12/12/17, 15:06

Commit message

Because with Random::generateRandomBytes() a strong CSPRNG is in
place, there is no more reason to allow (potentially insecure)
salts.

The same takes place in php, which deprecates custom salts as of
php 7.0.0.

Review

  • Code review CR 0
  • Verified V 0

Files 5

Review log 67

  1. Christian Futterlieb uploaded patch set 1 05/08/17, 18:18

  2. TYPO3com voted on patch set 1 V +1 05/08/17, 18:24 Completed build in 05m 36s on Mon, 8 May, 08:24 PM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11273

  3. Oliver Klee commented on patch set 1 05/08/17, 18:52

    php -> PHP (both times)

    Md5Salt.php:111

    Here, it should also state that this is deprecated.

    Pbkdf2Salt.php:183

    Here, it should also state that this is deprecated.

    PhpassSalt.php:225

    Here, it should also state that this is deprecated.

    SaltInterface.php:51

    Please also always mention in which version of TYPO3 this parameter will be removed.
  4. Christian Futterlieb commented on patch set 1 CR -1 05/09/17, 09:46

    Wait, this change does not make sense at all. Because: the $salt argument is used like in php's crypt() function. Which expects not only a random nonce but a string containing information about the algorithm to use, its options and the nonce. I oversaw this fact, I think a bit of re-thinking this appropriate.
  5. Stefan Neufeind commented on patch set 1 12/07/17, 07:53

    @Christian: How to proceed here?
  6. Christian Futterlieb commented on patch set 1 12/12/17, 15:06

    > @Christian: How to proceed here? I'll abandon the change, it does not make any sense, as commented earlier. Thnks for the reminder.
  7. Christian Futterlieb abandoned the change 12/12/17, 15:06

    This change makes no sense at all as the salt is needed as in php's crypt() function.