Review TYPO3_8-7 Merged

52739[TASK] Resolve hidden dependency from EXT:backend to EXT:rsaauth

Kasper Ligaard CR +2 V +2 Easy +9 −5 updated 07/04/17, 21:24

Commit message

Moves always-executed code into a hook which only executes
if the rsaauth extension is installed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Claus Due +1
    • Oliver Klee +1
    • Kasper Ligaard +1
    • Wouter Wolters +1
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1315

  1. Kasper Ligaard uploaded patch set 1 05/09/17, 06:43

  2. TYPO3com voted on patch set 1 V +1 05/09/17, 06:49 Completed build in 05m 36s on Tue, 9 May, 08:49 AM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-114

  3. Stefan Neufeind voted on patch set 1 CR +1 05/09/17, 07:07

  4. Oliver Klee voted on patch set 1 CR +1 05/09/17, 08:38

  5. Markus Klein updated the commit message in patch set 2 05/09/17, 08:42

  6. TYPO3com voted on patch set 2 V +1 05/09/17, 08:50 Completed build in 07m 39s on Tue, 9 May, 10:50 AM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-115

  7. Oliver Klee voted on patch set 2 CR +1 05/09/17, 08:51

  8. Stefan Neufeind voted on patch set 2 CR +1 05/09/17, 08:52

  9. Kasper Ligaard voted on patch set 2 CR +1 05/09/17, 13:48

  10. Claus Due voted on patch set 2 CR +1 05/11/17, 12:40

  11. Wouter Wolters voted on patch set 2 CR +1 06/30/17, 18:59

  12. Jörg Bösche voted on patch set 2 CR +1 07/03/17, 06:05

  13. Kasper Ligaard commented on patch set 2 07/04/17, 21:21

    This was merged to master back en May, cf. https://review.typo3.org/#/c/52269/ - should be safe to merge to 8.7.
  14. Christian Kuhn voted on patch set 2 CR +2 V +2 07/04/17, 21:24

  15. Gerrit merged patch set 2 07/04/17, 21:24