Review main Merged

52751[BUGFIX] Check for enabled devlog inside devLog()

Benni Mack CR +2 V +2 Easy +13 −24 updated 06/14/17, 06:41

Commit message

Calling GeneralUtility::devLog() can be called but
the method itself should check whether the devlog
is enabled, instead of having third-party code
rely on checking the option with an if statement.

This effectively removes the need for checks on
if (TYPO3_DLOG) and the other two constants TYPO3_ERROR_DLOG
and TYPO3_EXCEPTION_DLOG in all callers' code.

Review

  • Code review CR +2
    • Susi Moog +2
    • Georg Ringer +1
  • Verified V +2
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1522

  1. Benni Mack uploaded patch set 1 05/10/17, 18:00

  2. TYPO3com voted on patch set 1 V +1 05/10/17, 18:05 Completed build in 04m 58s on Wed, 10 May, 08:05 PM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11352

  3. Benni Mack uploaded patch set 2 05/12/17, 04:35

  4. TYPO3com voted on patch set 2 V -1 05/12/17, 04:39 Completed build in 03m 19s on Fri, 12 May, 06:39 AM Test Summary: 2249 of 55788 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11447

  5. Oliver Klee commented on patch set 2 05/12/17, 09:45

    DatabaseConnection.php:1880

    This comment should also go away, if I read it correctly.
  6. Christian Kuhn commented on patch set 2 05/12/17, 10:43

    neat.

    GeneralUtility.php:3908

    dubplicate i in "liine" ;)
  7. Benni Mack commented on patch set 3 05/12/17, 13:51

    Published edit on patch set 2.
  8. Benni Mack commented on patch set 4 05/12/17, 13:52

    Published edit on patch set 3.
  9. TYPO3com voted on patch set 3 V -1 05/12/17, 13:55 Completed build in 03m 44s on Fri, 12 May, 03:55 PM Test Summary: 2249 of 55788 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11465

  10. TYPO3com voted on patch set 4 V -1 05/12/17, 13:58 Completed build in 05m 55s on Fri, 12 May, 03:58 PM Test Summary: 2249 of 55788 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11466

  11. Benni Mack uploaded patch set 5 05/19/17, 05:25

  12. TYPO3com voted on patch set 5 V -1 05/19/17, 05:29 Completed build in 03m 18s on Fri, 19 May, 07:29 AM Test Summary: 2249 of 55824 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11580

  13. Benni Mack uploaded patch set 6 05/19/17, 12:27

  14. Oliver Klee voted on patch set 6 CR +1 05/19/17, 12:31

  15. TYPO3com voted on patch set 6 V +1 05/19/17, 12:33 Completed build in 06m 38s on Fri, 19 May, 02:33 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11590

  16. Andreas Kienast commented on patch set 6 05/19/17, 12:47

    We should add an Important.rst for this, do you agree?
  17. Benni Mack uploaded patch set 7 06/12/17, 05:27

  18. TYPO3com voted on patch set 7 V +1 06/12/17, 05:37 Completed build in 09m 48s on Mon, 12 Jun, 07:37 AM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12510

  19. Georg Ringer voted on patch set 7 CR +1 V +1 06/13/17, 05:40

  20. Susi Moog voted on patch set 7 CR +2 V +2 06/14/17, 06:41

  21. Gerrit merged patch set 7 06/14/17, 06:41

  22. Susi Moog commented on patch set 8 06/14/17, 06:41

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d9eba339f2fa355f58d9fa9da824429468486c21