Review main Merged

52754[BUGFIX] Remove doubled SQL query in PageRepository

Benni Mack CR +2 V +2 Easy +4 −25 updated 05/18/17, 14:08

Commit message

The method PageRepository->checkWorkspaceAccess() does a SQL query to fetch
the workspace record, then hands it over to BE_USER->checkWorkspace which has the
same functionality - to fetch the full workspace record.

As this is redundant code, the PageRepository code can be simplified a lot by just leaving
the workspaceCache property.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 05/11/17, 06:22

  2. TYPO3com voted on patch set 1 V +1 05/11/17, 06:27 Completed build in 05m 20s on Thu, 11 May, 08:27 AM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11364

  3. Benni Mack commented on patch set 2 05/11/17, 06:30

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 05/11/17, 06:36 Completed build in 05m 19s on Thu, 11 May, 08:36 AM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11366

  5. Jan Helke voted on patch set 2 CR +1 V +1 05/18/17, 14:03

  6. Christian Kuhn voted on patch set 2 CR +2 V +2 05/18/17, 14:08

  7. Gerrit merged patch set 2 05/18/17, 14:08

  8. Christian Kuhn commented on patch set 3 05/18/17, 14:08

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ade5e8ddfadf90effd180817c701e7b347415073