Review main Merged

52771[BUGFIX] Flexform Form ID should not contain brackets

Benjamin Serfhos CR +2 V +2 Easy +1 −2 updated 10/30/17, 08:50

Commit message

Using brackets in flexform elements caused the javascript to be disabled
for the element.
While using a custom form id that can be used as HTML id="" this is
bypassed and fixes all javascript interaction.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Markus Klein +1
    • Frank Nägler +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1824

  1. Benjamin Serfhos uploaded patch set 1 05/11/17, 12:30

  2. Benjamin Serfhos updated the commit message in patch set 2 05/11/17, 12:34

  3. TYPO3com voted on patch set 1 V +1 05/11/17, 12:39 Completed build in 08m 46s on Thu, 11 May, 02:39 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11390

  4. TYPO3com voted on patch set 2 V +1 05/11/17, 12:44 Completed build in 10m 14s on Thu, 11 May, 02:44 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11391

  5. Claus Due commented on patch set 2 05/11/17, 14:20

    Looks fine to me, but are there other characters we should be targeting? Unicode chars? Slashes? Would perhaps a preg_replace(^[a-z0-9]) make sense?
  6. Benjamin Serfhos updated the commit message in patch set 3 05/11/17, 14:32

  7. Benjamin Serfhos uploaded patch set 4 05/11/17, 14:33

  8. TYPO3com commented on patch set 3 05/11/17, 14:38 Completed build in 06m 23s on Thu, 11 May, 04:38 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11421

  9. TYPO3com voted on patch set 4 V -1 05/11/17, 14:40 Completed build in 07m 21s on Thu, 11 May, 04:40 PM Test Summary: 1 of 55917 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11422

  10. Jan Helke commented on patch set 4 05/11/17, 14:53

    I am against backporting that to 7.6. As this code is in for over two years, I wouldn't consider that a critical issue
  11. Christian Kuhn commented on patch set 4 05/11/17, 14:56

    needs verification. will need some time for this.
  12. Benjamin Serfhos updated the commit message in patch set 5 05/11/17, 15:27

  13. TYPO3com voted on patch set 5 V +1 05/11/17, 15:32 Completed build in 05m 46s on Thu, 11 May, 05:32 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11429

  14. Frank Nägler commented on patch set 5 CR +1 V +1 10/27/17, 21:45

    @lolli the fix is valid, the fix remove all invalid characters to build a correct ID. Another solution could be co generate a md5 hash, but a human readable name could be helpful with debugging. I am not sure about the backport for 7, imho master and v8 is enough
  15. Frank Nägler updated the commit message in patch set 6 10/27/17, 21:46

  16. Frank Nägler voted on patch set 6 CR +1 V +1 10/27/17, 21:47

  17. TYPO3com voted on patch set 6 V +1 10/27/17, 21:56 Completed build in 09m 05s on Fri, 27 Oct, 11:56 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15894

  18. Markus Klein commented on patch set 6 10/27/17, 22:02

    FlexFormElementContainer.php:113

    why replacing underscore again with underscore ;-)
  19. Frank Nägler commented on patch set 6 10/27/17, 22:09

    FlexFormElementContainer.php:113 Reply

    haha, good catch ;) to late... I will stop reviews today ...
  20. Frank Nägler commented on patch set 6 10/27/17, 22:11

    FlexFormElementContainer.php:113 Reply

    no.. the regexp is negated, it replace the character, if it is NOT an underscore... the regExp is fine ;)
  21. Markus Klein commented on patch set 6 CR +1 10/27/17, 23:22

    FlexFormElementContainer.php:113 Reply

    Ah... oh... ehm... ;-) right.
  22. Tymoteusz Motylewski commented on patch set 6 CR +2 V +2 10/30/17, 08:49

    looks good, works well ;)
  23. Gerrit merged patch set 6 10/30/17, 08:49

  24. Tymoteusz Motylewski commented on patch set 7 10/30/17, 08:50

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit db97cedaea25c1f0e23198668d92850905afe892