Review main Merged

52774[TASK] Move LanguageService to EXT:core

Benni Mack CR +2 V +2 Hard +270 −236 updated 05/12/17, 17:43

Commit message

The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization"
namespace, where all other related XLF/XML factory, store and parser classes reside.

This is done in order to streamline the localization of core-relevant files, since this class will
also be used in frontend context.

EXT:lang now contains the backend module, as well as most XLF files.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Jan Helke +1
  • Verified V +2
    • Georg Ringer +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 229

Show 209 more files

Review log 914

  1. Benni Mack uploaded patch set 1 05/11/17, 13:10

  2. TYPO3com voted on patch set 1 V -1 05/11/17, 13:17 Completed build in 06m 47s on Thu, 11 May, 03:17 PM Test Summary: 184 of 55917 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11399

  3. Benni Mack uploaded patch set 2 05/11/17, 15:33

  4. TYPO3com voted on patch set 2 V -1 05/11/17, 15:33 Completed build in 06s on Thu, 11 May, 05:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11430

  5. Benni Mack uploaded patch set 3 05/11/17, 15:34

  6. TYPO3com voted on patch set 3 V -1 05/11/17, 15:38 Completed build in 03m 59s on Thu, 11 May, 05:38 PM Test Summary: 2217 of 2290 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11432

  7. Benni Mack commented on patch set 4 05/11/17, 20:22

    Published edit on patch set 3.
  8. TYPO3com voted on patch set 4 V +1 05/11/17, 20:29 Completed build in 06m 27s on Thu, 11 May, 10:29 PM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11445

  9. Georg Ringer commented on patch set 4 05/12/17, 07:29

    Important-81196-LanguageServiceMovedToCoreExtension.rst:17

    this class alias will be removed in 10 I guess? should that be mentioned?
  10. Benni Mack commented on patch set 5 05/12/17, 08:25

    Published edit on patch set 4.
  11. TYPO3com voted on patch set 5 V +1 05/12/17, 08:32 Completed build in 06m 46s on Fri, 12 May, 10:32 AM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11453

  12. Jan Helke voted on patch set 5 CR +1 V +1 05/12/17, 15:01

  13. Georg Ringer voted on patch set 5 CR +2 V +2 05/12/17, 17:43

  14. Gerrit merged patch set 5 05/12/17, 17:43