52782[!!!][TASK] Drop TSFE->dtdAllowsFrames
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/master/Breaking-80700-DeprecatedFunctionalityRemoved.rst+1 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+0 −18
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+0 −20
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+0 −41
Review log 810
-
Benni Mack uploaded patch set 1 05/11/17, 15:41
-
TYPO3com voted on patch set 1 V +1 05/11/17, 15:46 Completed build in 05m 33s on Thu, 11 May, 05:46 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11433
-
Wouter Wolters voted on patch set 1 CR +1 V +1 05/11/17, 19:04
-
Christian Kuhn commented on patch set 1 CR -1 05/11/17, 19:23
there are still hits on this in: sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php -
Benni Mack uploaded patch set 2 05/12/17, 04:45
-
Benni Mack commented on patch set 2 05/12/17, 04:45
Yes - I saw that initially - the code was not evaluated anymore, so I did not care about that, but I checked again, and decided to remove the whole part -
TYPO3com voted on patch set 2 V +1 05/12/17, 04:51 Completed build in 05m 58s on Fri, 12 May, 06:51 AM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11449
-
Wouter Wolters commented on patch set 2 CR +1 V +1 05/12/17, 10:13
hmm, don;t know how I could have missed that... -
Christian Kuhn voted on patch set 2 CR +2 V +2 05/12/17, 10:39
-
Gerrit merged patch set 2 05/12/17, 10:39