52784[TASK] Convert remaining ViewHelpers to static calling
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Georg Ringer +1
- Wouter Wolters +1
-
Verified V +2
- Benni Mack +2
- Wouter Wolters +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/core/Classes/ViewHelpers/IconForRecordViewHelper.php1+12 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Widget/PaginateViewHelper.php2+21 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php3+31 −27
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ValidationResultsViewHelper.php+17 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CaseViewHelper.php+3 −18
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/UriViewHelper.php+35 −25
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php2+46 −54
- typo3/sysext/fluid/Classes/ViewHelpers/RenderChildrenViewHelper.php+31 −19
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/CObjectViewHelperTest.php+11 −5
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Link/ClickEnlargeViewHelper.php+3 −14
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/DateTimeViewHelper.php+3 −12
- typo3/sysext/install/Classes/ViewHelpers/File/RelativePathViewHelper.php+3 −14
- typo3/sysext/install/Classes/ViewHelpers/PhpInfoViewHelper.php+3 −14
Review log 3240
Show 915 earlier messages
-
Claus Due uploaded patch set 1 05/11/17, 18:59
-
Wouter Wolters commented on patch set 1 05/11/17, 19:03
-
TYPO3com voted on patch set 1 V -1 05/11/17, 19:05 Completed build in 05m 41s on Thu, 11 May, 09:05 PM Test Summary: 10 of 55917 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11438
-
Claus Due uploaded patch set 2 05/11/17, 19:12
-
TYPO3com voted on patch set 2 V -1 05/11/17, 19:18 Completed build in 05m 55s on Thu, 11 May, 09:18 PM Test Summary: 10 of 55917 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11440
-
Claus Due uploaded patch set 3 05/11/17, 19:53
-
Claus Due uploaded patch set 4 05/11/17, 19:55
-
TYPO3com voted on patch set 3 V -1 05/11/17, 19:59 Completed build in 05m 12s on Thu, 11 May, 09:59 PM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11442
-
TYPO3com voted on patch set 4 V +1 05/11/17, 20:03 Completed build in 07m 47s on Thu, 11 May, 10:03 PM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11443
-
Wouter Wolters voted on patch set 4 CR +1 05/12/17, 11:09
-
Jan Helke voted on patch set 4 CR +1 V +1 05/12/17, 14:58
-
Claus Due uploaded patch set 5 05/12/17, 19:32
-
TYPO3com voted on patch set 5 V -1 05/12/17, 19:38 Completed build in 06m 07s on Fri, 12 May, 09:38 PM Test Summary: 24 of 55853 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11471
-
Claus Due uploaded patch set 6 05/21/17, 14:24
-
TYPO3com voted on patch set 6 V +1 05/21/17, 14:30 Completed build in 06m 01s on Sun, 21 May, 04:30 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11658
-
Wouter Wolters voted on patch set 6 CR +1 05/22/17, 11:11
-
Oliver Klee commented on patch set 6 05/22/17, 12:00
IconForRecordViewHelper.php:55Why are you removing the return type annotation here? (I haven't checked the other VHs for this, though.)JsonEncodeViewHelper.php:27Why are you removing this VH? (And if it really show go away, that would be beyond the scope of this TASK and should have its own !!! TASK.) -
Wouter Wolters commented on patch set 6 05/22/17, 12:18
JsonEncodeViewHelper.php:27ReplyThis can be handled this way. This is an internal viewhelper of the core. Not for use in 3rd party extensions. And IMO can be done within this patch. This patch replaces the usage of this ViewHelper with an existing one. -
Claus Due commented on patch set 6 05/22/17, 12:46
JsonEncodeViewHelper.php:27ReplyYep, sorry about the slightly unrelated change. I can extract this to another patch set if you want, but I don't think it hurts since the only template it gets used in, is one you can't override with API. -
Oliver Klee commented on patch set 6 05/22/17, 13:04
JsonEncodeViewHelper.php:27ReplyYes, please. -
Claus Due uploaded patch set 7 05/22/17, 15:13
-
Claus Due commented on patch set 7 05/22/17, 15:20
Split per request, second merge request is in https://review.typo3.org/#/c/52903/ -
Oliver Klee commented on patch set 7 05/22/17, 15:27
Looks generally good to me.PageRendererViewHelper.php:112Can we have return type hinting here?PaginateViewHelper.php:80We need the @throws annotation here. -
TYPO3com voted on patch set 7 V +1 05/22/17, 15:27 Completed build in 13m 50s on Mon, 22 May, 05:27 PM Test Summary: 55887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11701
-
Claus Due uploaded patch set 8 05/22/17, 15:46
-
Claus Due commented on patch set 7 05/22/17, 15:47
Changed thrown exception to the proper ViewHelper Exception that won't destroy rendering if an input error occurs in production mode.PageRendererViewHelper.php:112ReplyFile is not strict mode enabled and I think the policy is to not declare returns unless entire file is strict. -
TYPO3com voted on patch set 8 V +1 05/22/17, 16:00 Completed build in 13m 36s on Mon, 22 May, 06:00 PM Test Summary: 55887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11711
-
Wouter Wolters voted on patch set 8 CR +1 06/01/17, 20:52
-
Wouter Wolters voted on patch set 8 V +1 06/05/17, 09:49
-
Georg Ringer voted on patch set 8 CR -1 06/05/17, 17:33
-
Claus Due commented on patch set 8 06/06/17, 09:59
Why the -1, Georg? -
Claus Due commented on patch set 8 06/11/17, 10:48
Still eager to hear why you voted -1, Georg. -
Georg Ringer commented on patch set 8 CR +1 06/12/17, 09:12
sry wrong button. -
Benni Mack voted on patch set 8 CR +2 V +2 06/12/17, 19:14
-
Gerrit merged patch set 8 06/12/17, 19:14
-
Daniel Goerz commented on patch set 9 08/24/18, 12:23
PaginateViewHelper.php:85Why did we allow $objects to be of type ObjectStorage or Array with this patch? The PaginateController calls ->getQuery() on $objects which neither of those two has. Am I missing something here? -
Daniel Goerz commented on patch set 9 08/25/18, 13:07
In case this ever gets backported, please keep https://review.typo3.org/#/c/58038/ in mind -
Mathias Brodala commented on patch set 9 08/27/18, 09:19
In light of the mentioned regression and the slight complexity of this change I'd vote for not backporting this to v8. From what I can see it is not really a pressing issue which requires this change but a nice to have improvement instead. -
Christian Kuhn commented on patch set 9 12/21/21, 08:40
CObjectViewHelper.php:123This dropped usage of $this->arguments['data'] entirely. -
Christian Kuhn commented on patch set 9 12/21/21, 09:24
CObjectViewHelper.php:123Reply Unresolvedmmmh. maybe not. but it would be better to set property $contentArgumentName to clearify - similar with other VH's.
PageRendererViewHelper.php:68