Review main Abandoned

52795[WIP][CLEANUP] Move resolveBackPath to PathUtility

Elmar Hinz CR 0 V 0 Normal +34 −20 updated 02/12/18, 19:21

Commit message

Test baloon,

- if path related methods should be migrated from GeneralUtility
   to PathUtility.
- if the methods should get a facelift for their names in this step.
- when the old API should be deprecated.
- what else may be related.

Ways to go:

1. Migrate method by method:

- Has one deprecation file each.
- The redirect triggers the deprecation call.
- Implementation of new location is done throughout the core.
- Update related unit tests.

2. Migrate all at once:

- Has one deprecation file for all.
- Provides only redirects and deprecation calls.
- Implementation of new locations is done in later steps.
- Update of related unit tests is done in later steps.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 34

  1. Elmar Hinz uploaded patch set 1 05/12/17, 13:57

  2. TYPO3com voted on patch set 1 V +1 05/12/17, 14:03 Completed build in 05m 46s on Fri, 12 May, 04:03 PM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11467

  3. Christian Kuhn commented on patch set 1 02/12/18, 19:21

    hey elmar. i think we should abandon this patch for now: the path area is still a rather huge wip part and needs more systematic works than just moving methods around. doing a move of path related methods just now does not really help us right now and only adds another layer to devs who then later need to change things twice. i hope it is ok if we right now don't accept this approach and have a deeper look at what is left as soon as we got the main path resolving right.
  4. Christian Kuhn abandoned the change 02/12/18, 19:21