Review main Merged

52817[BUGFIX] Typo3DBQueryParser fails to wrap subselect in braces

Thomas Maroschik CR +2 V +2 Easy +1 −1 updated 05/18/17, 12:45

Commit message

When the Typo3DBQueryParser converts Extbase queries to Doctrine
queries, it creates subselects for certain relation constraints.
It fails to wrap the subselect in braces for has-many relations
which leads to sql exceptions.

This patch introduces braces around those subselects.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Jan Helke +1
    • Henrik Elsner +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1
    • TYPO3com +1 CI

Files 1

Review log 78

  1. Thomas Maroschik uploaded patch set 1 05/17/17, 10:34

  2. Henrik Elsner voted on patch set 1 CR +1 05/17/17, 10:39

  3. TYPO3com voted on patch set 1 V +1 05/17/17, 10:41 Completed build in 06m 57s on Wed, 17 May, 12:41 PM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11542

  4. Jan Helke voted on patch set 1 CR +1 V +1 05/17/17, 16:03

  5. Wouter Wolters voted on patch set 1 CR +1 05/18/17, 07:02

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 05/18/17, 12:45

  7. Gerrit merged patch set 1 05/18/17, 12:45

  8. Christian Kuhn commented on patch set 2 05/18/17, 12:45

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 592d7630bdf8e9698f20113ad3c114f126e1e1d4