Review main Merged

52822[BUGFIX] Use EXEC_TIME for sys_log entry instead of time()

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 05/18/17, 09:49

Commit message

DataHandler does a lookup in sys_log table after it performed
its operations to find relevant error entries for the current request.

It determines relevance by looking for entries with the same
timestamp as $GLOBALS['EXEC_TIME'].

However error log entries are written using time(). Now if the
DataHandler operations take longer than one second, or the log entry
is written directly before a next tick, it can happen, that errors
will not be detected during the lookup process.

Since such errors are exposed to the user, it can happen that an operation
fails, but the users will not be notified.

Fix this by using $GLOBALS['EXEC_TIME'] when writing the log entries.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Oliver Klee +1
    • Felix Rauch +1
    • Wouter Wolters +1
    • Andreas Kienast +1
    • Nicole Hummel +1
    • Philipp Gampe +1
  • Verified V +2
    • Helmut Hummel +2
    • Nicole Hummel +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 10

  1. Helmut Hummel uploaded patch set 1 05/17/17, 12:11

  2. Andreas Kienast voted on patch set 1 CR +1 05/17/17, 12:15

  3. Felix Rauch voted on patch set 1 CR +1 05/17/17, 12:16

  4. Nicole Hummel commented on patch set 1 CR +1 V +1 05/17/17, 12:16

    BackendUserAuthentication.php:2308

    just as reminder: different backport for 7.6 needed
  5. Wouter Wolters voted on patch set 1 CR +1 05/17/17, 12:25

  6. Oliver Klee voted on patch set 1 CR +1 05/17/17, 12:38

  7. Philipp Gampe voted on patch set 1 CR +1 V +1 05/18/17, 09:48

  8. Helmut Hummel commented on patch set 1 CR +2 V +2 05/18/17, 09:48

    Thanks!
  9. Gerrit merged patch set 1 05/18/17, 09:48

  10. Helmut Hummel commented on patch set 2 05/18/17, 09:49

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 6cc51d3ccaafaf1a11e73ddffc49aa14dde25e7d