Review main Merged

52829[BUGFIX] Keep MP parameters upon redirect of overlay

Elmar Hinz CR +2 V +2 Easy +5 −1 updated 10/28/18, 16:31

Commit message

When a mount point, that is overlayed, redirects to the overlaying page,
don't throw away existing mount point parameters. The other mount point
parameters may specify a mount point upwards in the root line.

Under normal circumstances the page should not be linked at all. However
a redirect is provided and as it is provided it should work as expected.

Review

  • Code review CR +2
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2433

Show 58 earlier messages
  1. Elmar Hinz uploaded patch set 1 05/17/17, 16:02

  2. TYPO3com voted on patch set 1 V -1 05/17/17, 16:08 Completed build in 05m 48s on Wed, 17 May, 06:08 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11551

  3. Elmar Hinz uploaded patch set 2 05/18/17, 07:16

  4. TYPO3com voted on patch set 2 V +1 05/18/17, 07:22 Completed build in 05m 23s on Thu, 18 May, 09:22 AM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11558

  5. Elmar Hinz updated the commit message in patch set 3 05/18/17, 07:27

  6. TYPO3com voted on patch set 3 V +1 05/18/17, 07:33 Completed build in 05m 32s on Thu, 18 May, 09:33 AM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11559

  7. Elmar Hinz updated the commit message in patch set 4 05/18/17, 09:58

  8. Andreas Kienast commented on patch set 4 05/18/17, 09:59

    TypoScriptFrontendController.php:1466

    ===
  1. Elmar Hinz commented on patch set 5 05/18/17, 10:00

    Published edit on patch set 4.
  2. TYPO3com voted on patch set 4 V +1 05/18/17, 10:06 Completed build in 07m 27s on Thu, 18 May, 12:06 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11562

  3. Elmar Hinz commented on patch set 5 05/18/17, 10:17

    How to verify? In the BE create two mount points. One is below the other in the root line. A normal page must be in between to not create a recursive mount point. The lower mount point must be overlaid. Given: 3 mounted on 2 (with or without overlay) 6 mounted on 5, with 6 overlaying 5 Expected: index.php?id=5&MP=3-2 should redirect to index.php?id=6&MP=3-2,6-5 The breadcrumb should show both mount points as specified.
  4. TYPO3com voted on patch set 5 V -1 05/18/17, 10:23 Completed build in 22m 33s on Thu, 18 May, 12:23 PM Test Summary: 1 of 55889 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11563

  5. Elmar Hinz rebased onto patch set 6 05/18/17, 10:34

  6. TYPO3com voted on patch set 6 V +1 05/18/17, 10:40 Completed build in 05m 54s on Thu, 18 May, 12:40 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11564

  7. Elmar Hinz updated the commit message in patch set 7 05/18/17, 12:03

  8. TYPO3com voted on patch set 7 V +1 05/18/17, 12:08 Completed build in 05m 27s on Thu, 18 May, 02:08 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11571

  9. Philipp Gampe commented on patch set 7 CR +1 05/18/17, 12:09

    Such a simple change ... what took you so long :P ‾\_('_')_/‾
  10. Benni Mack voted on patch set 7 CR +2 09/09/17, 21:14

  11. Sonja Großewinkelmann voted on patch set 7 CR +1 09/11/17, 08:30

  12. Tymoteusz Motylewski commented on patch set 7 09/11/17, 09:24

    Can you please describe a steps to reproduce/test in the ticket? It would help a lot to get verified votes. thanks.
  13. Tymoteusz Motylewski commented on patch set 7 09/11/17, 13:06

    Isn't this a duplicate of https://review.typo3.org/#/c/10100/11 or are they independent?
  14. Sascha Rademacher voted on patch set 7 CR +1 09/18/17, 08:38

  15. Mathias Schreiber commented on patch set 7 03/01/18, 21:05

    can someone PLEASE provide a few steps on how to reproduce?
  16. Steffen Frese voted on patch set 7 CR +1 03/06/18, 13:56

  17. Roberto Torresani voted on patch set 7 CR +1 05/11/18, 16:25

  18. Anja Leichsenring commented on patch set 7 06/10/18, 09:48

    > Patch Set 5: > > How to verify? > > In the BE create two mount points. One is below the other in the root line. A normal page must be in between to not create a recursive mount point. The lower mount point must be overlaid. > > Given: > > 3 mounted on 2 (with or without overlay) > 6 mounted on 5, with 6 overlaying 5 > > Expected: > > index.php?id=5&MP=3-2 > > should redirect to > > index.php?id=6&MP=3-2,6-5 > > The breadcrumb should show both mount points as specified. here are the reproduce steps
  19. Benni Mack updated the commit message in patch set 8 10/27/18, 20:08

  20. TYPO3com voted on patch set 8 V +1 10/27/18, 20:20 Completed build in 11m 36s on Sat, 27 Oct, 10:20 PM Test Summary: 37843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29697

  21. Benni Mack updated the commit message in patch set 9 10/28/18, 16:16

  22. TYPO3com voted on patch set 9 V +1 10/28/18, 16:31 Completed build in 14m 45s on Sun, 28 Oct, 05:31 PM Test Summary: 37891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29786

  23. Susi Moog voted on patch set 9 V +1 CR +1 10/28/18, 16:31

  24. Benni Mack voted on patch set 9 V +2 CR +2 10/28/18, 16:31

  25. Benni Mack merged patch set 10 10/28/18, 16:31