Review TYPO3_7-6 Merged

52840[BUGFIX] Use EXEC_TIME for sys_log entry instead of time()

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 05/18/17, 11:07

Commit message

DataHandler does a lookup in sys_log table after it performed
its operations to find relevant error entries for the current request.

It determines relevance by looking for entries with the same
timestamp as $GLOBALS['EXEC_TIME'].

However error log entries are written using time(). Now if the
DataHandler operations take longer than one second, or the log entry
is written directly before a next tick, it can happen, that errors
will not be detected during the lookup process.

Since such errors are exposed to the user, it can happen that an operation
fails, but the users will not be notified.

Fix this by using $GLOBALS['EXEC_TIME'] when writing the log entries.

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Helmut Hummel uploaded patch set 1 05/18/17, 10:45

  2. TYPO3com voted on patch set 1 V +1 05/18/17, 10:50 Completed build in 05m 46s on Thu, 18 May, 12:50 PM Test Summary: 38592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-943

  3. Helmut Hummel voted on patch set 1 CR +2 V +2 05/18/17, 11:06

  4. Gerrit merged patch set 1 05/18/17, 11:07