Review TYPO3_8-7 Merged

52854[BUGFIX] Remove doubled SQL query in PageRepository

Christian Kuhn CR +2 V +2 Easy +4 −25 updated 05/18/17, 15:00

Commit message

The method PageRepository->checkWorkspaceAccess() does a SQL query to fetch
the workspace record, then hands it over to BE_USER->checkWorkspace which has the
same functionality - to fetch the full workspace record.

As this is redundant code, the PageRepository code can be simplified a lot by just leaving
the workspaceCache property.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 05/18/17, 14:08

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 05/18/17, 14:17 Completed build in 08m 57s on Thu, 18 May, 04:17 PM Test Summary: 56774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-197

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 05/18/17, 15:00

  4. Gerrit merged patch set 1 05/18/17, 15:00