Review main Merged

52857[BUGFIX] Accept configuration for external plugins from presets in ckeditor

Marcus Schwemer CR +2 V +2 Easy +3 −0 updated 03/15/18, 11:01

Commit message

Currently the default configuration of an external
plugin is always used for the configuration. This patch takes care
of a proper merging of the configuration.

The configuration of the extension is taken as default. If a
custom configuration in a preset is available, both configurations
will be merged.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Mathias Schreiber +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2632

Show 57 earlier messages
  1. Marcus Schwemer uploaded patch set 1 05/18/17, 21:07

  2. Marcus Schwemer updated the commit message in patch set 2 05/18/17, 21:08

  3. TYPO3com voted on patch set 2 V +1 05/18/17, 21:23 Completed build in 14m 47s on Thu, 18 May, 11:23 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11579

  4. TYPO3com voted on patch set 1 V -1 05/18/17, 21:31 Completed build in 23m 48s on Thu, 18 May, 11:31 PM Test Summary: 1 of 55889 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11578

  5. Marcus Schwemer commented on patch set 2 05/18/17, 21:54

    I don't understand the -1 for patch set 1 of TYPO3com after a successful "+1" for patch set 2 Furthermore the link to the reports links to some totally unrelated. Who can help?
  6. Frank Nägler commented on patch set 2 05/19/17, 20:38

    RichTextElement.php:171

    that's a bit confusing on reading. please rename $config to something like $pluginConfiguration and $configuration to $editorConfiguration.
  7. Elmar Hinz commented on patch set 2 05/20/17, 05:31

    > I don't understand the -1 for patch set 1 of TYPO3com after a > successful "+1" for patch set 2 > > Furthermore the link to the reports links to some totally > unrelated. > > Who can help? The acceptance test sometimes fail for non-related reasons. Do a second try. If the same tests don't fail again, it was not caused by you change.
  1. Marcus Schwemer commented on patch set 2 06/02/17, 08:45

    > (1 comment) Thought about that too, but the naming is used the class, so it should be changed in other places too. What do think about improve the naming in an extra task / patch?
  2. Susi Moog voted on patch set 2 CR +1 06/02/17, 14:14

  3. Mona Muzaffar uploaded patch set 3 06/03/17, 16:30

  4. TYPO3com voted on patch set 3 V +1 06/03/17, 16:41 Completed build in 11m 19s on Sat, 3 Jun, 06:41 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12244

  5. Christian Kuhn commented on patch set 3 06/04/17, 09:30

    RichTextElement.php:172

    could we switch to array_merge_recursive here to explicitly NOT support __UNSET?
  6. Christian Kuhn commented on patch set 3 CR -1 06/09/17, 22:53

    RichTextElement.php:179

    else $configuration[$pluginName] = $config['config'];
  7. Christian Kuhn commented on patch set 3 06/09/17, 23:05

    I think the config merge operation belongs to method getExtraPlugins(): getExtraPlugins() does further operation on parts of the config: resource, route and routeUrl. If that is later overriden by default config again, it breaks the former calculation. Thus, i guess the config merge should go to that method, too. Is that correct?
  8. Marcus Schwemer commented on patch set 3 07/14/17, 21:33

    Because of the last comment, I'd like talk to you while the dev days. Its easier to agree about how to handle it F2F.

    RichTextElement.php:172 Reply

    IMO no, because we should allow to unset the default configuration of an extra plugin

    RichTextElement.php:179 Reply

    Will do this in the next patchset
  9. Susi Moog commented on patch set 3 09/20/17, 14:13

    how will you continue here?
  10. Marcus Schwemer commented on patch set 3 09/20/17, 18:40

    Didn't have the time in the last months ... but it is still on my radar ;-) I expect the next week to get easier going.
  11. Benni Mack commented on patch set 3 10/19/17, 21:42

    ping! I'm also in favor of using the native array_replace_recursive() PHP method.
  12. Mathias Schreiber commented on patch set 3 03/01/18, 21:00

    is there any activity here? Otherwise I'd drop this to get the amount of rolling reviews to a proper level.
  13. Marcus Schwemer uploaded patch set 4 03/02/18, 14:59

  14. TYPO3com voted on patch set 4 V +1 03/02/18, 15:07 Completed build in 07m 56s on Fri, 2 Mar, 04:07 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20441

  15. Frank Nägler voted on patch set 4 CR +1 03/02/18, 15:10

  16. Mathias Schreiber uploaded patch set 5 03/03/18, 21:13

  17. TYPO3com voted on patch set 5 V +1 03/03/18, 21:22 Completed build in 09m 45s on Sat, 3 Mar, 10:22 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20469

  18. Jörg Bösche voted on patch set 5 CR +1 03/05/18, 08:37

  19. Mathias Schreiber voted on patch set 5 V +1 CR +1 03/07/18, 17:46

  20. Georg Ringer updated the commit message in patch set 6 03/07/18, 20:19

  21. TYPO3com voted on patch set 6 V +1 03/07/18, 20:27 Completed build in 08m 27s on Wed, 7 Mar, 09:27 PM Test Summary: 30812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20650

  22. Mathias Schreiber voted on patch set 6 V +1 CR +1 03/08/18, 08:20

  23. Frank Nägler voted on patch set 6 V +2 CR +2 03/15/18, 11:01

  24. Frank Nägler merged patch set 7 03/15/18, 11:01

  25. Frank Nägler commented on patch set 7 03/15/18, 11:01

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d23e08a52f0b30bc483b3aee8c7e52eeace86304