Review main Merged

52859[BUGFIX] Make sure relative URL receives a proper host part for errorpage

Anja Leichsenring CR +2 V +2 Easy +2 −1 updated 05/19/17, 11:17

Commit message

If the code given for PageNotFound_handling is a relative URL, the host
determination gets skipped, resulting in a redirect of the markup of
the page instead a proper redirect.

Review

  • Code review CR +2
    • Benni Mack +2
    • Frank Nägler +1
    • Mathias Brodala +1
  • Verified V +2
    • Benni Mack +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1014

  1. Anja Leichsenring uploaded patch set 1 05/19/17, 09:50

  2. TYPO3com voted on patch set 1 V -1 05/19/17, 09:55 Completed build in 05m 04s on Fri, 19 May, 11:55 AM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11583

  3. Anja Leichsenring uploaded patch set 2 05/19/17, 09:56

  4. Mathias Brodala commented on patch set 3 05/19/17, 10:00

    Published edit on patch set 2.
  5. Mathias Brodala voted on patch set 3 CR +1 05/19/17, 10:01

  6. TYPO3com voted on patch set 2 V +1 05/19/17, 10:02 Completed build in 05m 36s on Fri, 19 May, 12:02 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11584

  7. TYPO3com voted on patch set 3 V +1 05/19/17, 10:07 Completed build in 07m 03s on Fri, 19 May, 12:07 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11585

  8. Frank Nägler commented on patch set 4 05/19/17, 10:45

    Published edit on patch set 3.
  9. Frank Nägler voted on patch set 4 CR +1 V +1 05/19/17, 10:45

  10. TYPO3com voted on patch set 4 V +1 05/19/17, 10:50 Completed build in 05m 08s on Fri, 19 May, 12:50 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11586

  11. Mathias Brodala voted on patch set 4 CR +1 05/19/17, 10:50

  12. Benni Mack voted on patch set 4 CR +2 V +2 05/19/17, 11:16

  13. Gerrit merged patch set 4 05/19/17, 11:16

  14. Benni Mack commented on patch set 5 05/19/17, 11:17

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 71f5c6c08491f81eb62250d5cfc55a86b81660c7