Review main Abandoned

52864[WIP][FEATURE] Use matthiasmullie/minify instead of own functions

Markus Sommer CR 0 V 0 Hard +133 −128 updated 02/21/18, 11:37

Commit message

Used composer command:
  composer req matthiasmullie/minify:~1.3.59

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1016

  1. Markus Sommer uploaded patch set 1 05/19/17, 12:08

  2. Markus Sommer updated the commit message in patch set 2 05/19/17, 12:09

  3. TYPO3com voted on patch set 1 V -1 05/19/17, 12:14 Completed build in 06m 16s on Fri, 19 May, 02:14 PM Test Summary: 96 of 55889 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11588

  4. TYPO3com voted on patch set 2 V -1 05/19/17, 12:15 Completed build in 06m 09s on Fri, 19 May, 02:15 PM Test Summary: 97 of 55889 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11589

  5. Jigal van Hemert commented on patch set 2 CR -1 05/24/17, 07:11

    Unit tests should also be changed as they test the functions that were removed. But at least the same functionality (moving those @.. parts, BOM marker removal, etc.) must be tested.

    ResourceCompressor.php:291

    This function only concatenates the CSS/JS files. No further processing is expected here.
  6. Tymoteusz Motylewski commented on patch set 2 05/29/17, 18:17

    indeed -> instead
  7. Benni Mack uploaded patch set 3 02/10/18, 22:42

  8. Benni Mack updated the commit message in patch set 4 02/10/18, 22:43

  9. Benni Mack updated the commit message in patch set 5 02/10/18, 22:45

  10. TYPO3com voted on patch set 3 V -1 02/10/18, 22:52 Completed build in 10m 19s on Sat, 10 Feb, 11:52 PM Test Summary: 56 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19319

  11. TYPO3com voted on patch set 4 V -1 02/10/18, 22:53 Completed build in 10m 31s on Sat, 10 Feb, 11:53 PM Test Summary: 56 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19320

  12. TYPO3com voted on patch set 5 V -1 02/10/18, 22:55 Completed build in 09m 56s on Sat, 10 Feb, 11:55 PM Test Summary: 56 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19321

  13. Andreas Kienast uploaded patch set 6 02/19/18, 20:23

  14. TYPO3com voted on patch set 6 V -1 02/19/18, 20:31 Completed build in 07m 59s on Mon, 19 Feb, 09:31 PM Test Summary: 56 of 31054 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19882

  15. Armin Vieweg commented on patch set 6 02/21/18, 10:50

    btw. EXT:min also uses this library.
  16. Georg Ringer abandoned the change 02/21/18, 11:37

    plans are to use https://review.typo3.org/c/51051/ instead