52875[CLEANUP] Review comment and sig of getSubpagesForPages()
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Benni Mack +1
-
Verified V +2
- Jigal van Hemert +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1421
-
Elmar Hinz uploaded patch set 1 05/20/17, 10:00
-
TYPO3com voted on patch set 1 V +1 05/20/17, 10:09 Completed build in 09m 02s on Sat, 20 May, 12:09 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11601
-
Oliver Klee commented on patch set 1 05/20/17, 10:09
<3PageRepository.php:710We then also can have the return type hint (array). -
Elmar Hinz uploaded patch set 2 05/20/17, 10:10
-
TYPO3com voted on patch set 2 V +1 05/20/17, 10:15 Completed build in 05m 03s on Sat, 20 May, 12:15 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11602
-
Elmar Hinz uploaded patch set 3 05/20/17, 10:18
-
Elmar Hinz updated the commit message in patch set 4 05/20/17, 10:24
-
TYPO3com voted on patch set 3 V +1 05/20/17, 10:25 Completed build in 07m 25s on Sat, 20 May, 12:25 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11604
-
Elmar Hinz uploaded patch set 5 05/20/17, 10:27
-
TYPO3com voted on patch set 4 V +1 05/20/17, 10:31 Completed build in 06m 42s on Sat, 20 May, 12:31 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11606
-
TYPO3com voted on patch set 5 V +1 05/20/17, 10:33 Completed build in 05m 55s on Sat, 20 May, 12:33 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11607
-
Oliver Klee commented on patch set 5 05/20/17, 10:41
I can proofread the change request. Would you like me to add comments (so that you can do the changes) or to directly push a new version? -
Elmar Hinz commented on patch set 5 05/20/17, 12:35
> I can proofread the change request. Would you like me to add > comments (so that you can do the changes) or to directly push a new > version? Please edit directly. Less work. Thank you. -
Oliver Klee uploaded patch set 6 05/20/17, 12:48
-
TYPO3com voted on patch set 6 V +1 05/20/17, 12:54 Completed build in 06m 03s on Sat, 20 May, 02:54 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11612
-
Benni Mack uploaded patch set 7 12/18/17, 19:37
-
TYPO3com voted on patch set 7 V +1 12/18/17, 19:44 Completed build in 07m 07s on Mon, 18 Dec, 08:44 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17864
-
Benni Mack voted on patch set 7 V +1 CR +1 12/18/17, 19:45
-
Oliver Klee wrote 12/18/17, 19:54
Removed reviewer Oliver Klee. -
Jigal van Hemert voted on patch set 7 V +2 CR +2 12/18/17, 20:05
-
Jigal van Hemert merged patch set 8 12/18/17, 20:05