Review main Merged

52878[CLEANUP] Review comment of PageRepository::getPage()

Elmar Hinz CR +2 V +2 Easy +25 −7 updated 10/02/17, 05:07

Commit message

Note:

Type hints are not trivial to add to the signature. Although the
method always returns an array, there are unit tests that make use
of the assumption that the method is allowed to return null. Fixing
this goes beyond the goals of this ticket.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2

Issues 1

Files 1

Review log 1321

  1. Elmar Hinz uploaded patch set 1 05/20/17, 14:11

  2. TYPO3com voted on patch set 1 V -1 05/20/17, 14:19 Completed build in 07m 35s on Sat, 20 May, 04:19 PM Test Summary: 26 of 55889 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11617

  3. Oliver Klee commented on patch set 1 05/20/17, 14:28

    PageRepository.php:216

    Generally, UID and PID should be uppercase (in text, not in variable names).
  4. Elmar Hinz uploaded patch set 2 05/20/17, 14:40

  5. TYPO3com voted on patch set 2 V -1 05/20/17, 14:46 Completed build in 05m 42s on Sat, 20 May, 04:46 PM Test Summary: 26 of 55889 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11618

  6. Elmar Hinz uploaded patch set 3 05/20/17, 15:48

  7. Elmar Hinz updated the commit message in patch set 4 05/20/17, 15:51

  8. TYPO3com voted on patch set 3 V -1 05/20/17, 15:54 Completed build in 05m 57s on Sat, 20 May, 05:54 PM Test Summary: 9 of 55885 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11622

  9. Elmar Hinz updated the commit message in patch set 5 05/20/17, 15:56

  10. TYPO3com voted on patch set 4 V +1 05/20/17, 15:58 Completed build in 06m 43s on Sat, 20 May, 05:58 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11623

  11. TYPO3com voted on patch set 5 V +1 05/20/17, 16:02 Completed build in 05m 58s on Sat, 20 May, 06:02 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11624

  12. Elmar Hinz uploaded patch set 6 05/29/17, 12:42

  13. TYPO3com voted on patch set 6 V -1 05/29/17, 12:48 Completed build in 06m 18s on Mon, 29 May, 02:48 PM Test Summary: 1 of 55892 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11860

  14. Elmar Hinz rebased onto patch set 7 05/30/17, 19:28

  15. TYPO3com voted on patch set 7 V +1 05/30/17, 19:35 Completed build in 06m 25s on Tue, 30 May, 09:35 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11894

  16. Wouter Wolters commented on patch set 7 CR -1 06/05/17, 09:50

    PageRepository.php:232

    Is is -> It is
  17. Benni Mack commented on patch set 8 10/02/17, 04:52

    Published edit on patch set 7.
  18. Benni Mack voted on patch set 8 CR +2 V +2 10/02/17, 04:52

  19. Gerrit merged patch set 8 10/02/17, 04:52

  20. Benni Mack commented on patch set 9 10/02/17, 04:53

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 9c95730fed67515d2be31d4675558761571060d6
  21. TYPO3com commented on patch set 8 10/02/17, 05:07 Completed build in 14m 52s on Mon, 2 Oct, 07:07 AM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15242