Review main Merged

52879[TASK] Remove usage of PATH_typo3conf from ConfigurationManager

Anja Leichsenring CR +2 V +2 Easy +3 −15 updated 05/22/17, 11:11

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1115

  1. Anja Leichsenring uploaded patch set 1 05/20/17, 17:58

  2. TYPO3com voted on patch set 1 V -1 05/20/17, 18:04 Completed build in 05m 52s on Sat, 20 May, 08:04 PM Test Summary: 6 of 55889 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11628

  3. Anja Leichsenring commented on patch set 2 05/20/17, 18:15

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 05/20/17, 18:21 Completed build in 05m 51s on Sat, 20 May, 08:21 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11629

  5. Christian Kuhn commented on patch set 2 CR -1 05/20/17, 22:29

    ConfigurationManager.php:71

    property still used in test.
  6. Anja Leichsenring uploaded patch set 3 05/21/17, 10:42

  7. Anja Leichsenring uploaded patch set 4 05/21/17, 10:43

  8. TYPO3com voted on patch set 3 V -1 05/21/17, 10:48 Completed build in 06m 18s on Sun, 21 May, 12:48 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11647

  9. TYPO3com voted on patch set 4 V +1 05/21/17, 10:51 Completed build in 07m 51s on Sun, 21 May, 12:51 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11648

  10. Oliver Klee voted on patch set 4 CR +1 05/21/17, 11:04

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 05/21/17, 11:10

  12. Jan Helke voted on patch set 4 CR +1 V +1 05/22/17, 11:09

  13. Christian Kuhn voted on patch set 4 CR +2 V +2 05/22/17, 11:11

  14. Gerrit merged patch set 4 05/22/17, 11:11

  15. Christian Kuhn commented on patch set 5 05/22/17, 11:11

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d397bdb7731a65d3a0bcd56e730621c10c17d5d8