Review main Merged

52892[CLEANUP] Review comment of fetch_the_id

Elmar Hinz CR +2 V +2 Normal +57 −3 updated 10/02/17, 04:42

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 915

  1. Elmar Hinz uploaded patch set 1 05/21/17, 17:54

  2. TYPO3com voted on patch set 1 V +1 05/21/17, 18:01 Completed build in 06m 23s on Sun, 21 May, 08:01 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11663

  3. Elmar Hinz updated the commit message in patch set 2 05/21/17, 18:17

  4. TYPO3com voted on patch set 2 V +1 05/21/17, 18:22 Completed build in 05m 32s on Sun, 21 May, 08:22 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11664

  5. Georg Ringer commented on patch set 2 CR -1 05/22/17, 08:28

    TypoScriptFrontendController.php:787

    either deprecate it or leave it as it is ...
  6. Elmar Hinz uploaded patch set 3 05/22/17, 15:06

  7. Elmar Hinz updated the commit message in patch set 4 05/22/17, 15:29

  8. TYPO3com voted on patch set 3 V +1 05/22/17, 15:36 Completed build in 30m 34s on Mon, 22 May, 05:36 PM Test Summary: 55887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11700

  9. TYPO3com voted on patch set 4 V +1 05/22/17, 15:38 Completed build in 08m 54s on Mon, 22 May, 05:38 PM Test Summary: 55887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11703

  10. Elmar Hinz updated the commit message in patch set 5 05/22/17, 17:10

  11. TYPO3com voted on patch set 5 V -1 05/22/17, 17:16 Completed build in 05m 15s on Mon, 22 May, 07:16 PM Test Summary: 1 of 55892 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11724

  12. Elmar Hinz rebased onto patch set 6 05/22/17, 17:20

  13. TYPO3com voted on patch set 6 V +1 05/22/17, 17:28 Completed build in 07m 52s on Mon, 22 May, 07:28 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11725

  14. Benni Mack voted on patch set 6 CR +2 V +2 10/02/17, 04:42

  15. Gerrit merged patch set 6 10/02/17, 04:42