Review main Merged

52895[CLEANUP] Review comment and sig of checkRootlineForIncludeSection()

Elmar Hinz CR +2 V +2 Easy +35 −11 updated 12/27/17, 15:01

Commit message

Reviews the comments and signatures of:

TypoScriptFrontendController::checkRootlineForIncludeSection()
TypoScriptFrontendController::checkPagerecordForIncludeSection()

Casts the return values to bool.

Review

  • Code review CR +2
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1119

  1. Elmar Hinz uploaded patch set 1 05/22/17, 10:00

  2. TYPO3com voted on patch set 1 V +1 05/22/17, 10:08 Completed build in 08m 01s on Mon, 22 May, 12:08 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11666

  3. Elmar Hinz uploaded patch set 2 05/22/17, 10:10

  4. Elmar Hinz uploaded patch set 3 05/22/17, 10:12

  5. TYPO3com voted on patch set 2 V +1 05/22/17, 10:19 Completed build in 08m 41s on Mon, 22 May, 12:19 PM Test Summary: 55887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11669

  6. TYPO3com voted on patch set 3 V +1 05/22/17, 10:22 Completed build in 09m 29s on Mon, 22 May, 12:22 PM Test Summary: 55887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11670

  7. Elmar Hinz uploaded patch set 4 05/22/17, 10:39

  8. TYPO3com voted on patch set 4 V +1 05/22/17, 10:46 Completed build in 06m 53s on Mon, 22 May, 12:46 PM Test Summary: 55887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11672

  9. Benni Mack rebased onto patch set 5 11/30/17, 14:34

  10. TYPO3com voted on patch set 5 V +1 11/30/17, 14:44 Completed build in 09m 35s on Thu, 30 Nov, 03:44 PM Test Summary: 57038 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17119

  11. Oliver Klee commented on patch set 5 11/30/17, 14:52

    TypoScriptFrontendController.php:1681

    Can't we use true/false in the first place?

    TypoScriptFrontendController.php:1739

    TRUE -> true visble -> visible
  12. Benni Mack commented on patch set 6 12/09/17, 02:15

    Published edit on patch set 5.
  13. TYPO3com voted on patch set 6 V -1 12/09/17, 02:25 Completed build in 09m 54s on Sat, 9 Dec, 03:25 AM Test Summary: 10 of 57396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17444

  14. TYPO3com commented on patch set 6 12/09/17, 09:06 Completed build in 7h 00m 32s on Sat, 9 Dec, 10:06 AM Test Summary: 1 of 57396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17444

  15. Benni Mack rebased onto patch set 7 12/27/17, 14:35

  16. TYPO3com voted on patch set 7 V +1 12/27/17, 14:42 Completed build in 07m 29s on Wed, 27 Dec, 03:42 PM Test Summary: 29987 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17983

  17. Anja Leichsenring voted on patch set 7 V +1 CR +1 12/27/17, 14:59

  18. Benni Mack voted on patch set 7 V +2 CR +2 12/27/17, 15:01

  19. Benni Mack merged patch set 8 12/27/17, 15:01