Review main Merged

52903[TASK] Remove duplicate ViewHelper from extensionmanager

Claus Due CR +2 V +2 Normal +1 −70 updated 06/24/17, 11:52

Commit message

JSON encoding ViewHelper from Fluid is fully compatible.
Also removes a number of unused arguments in the Fluid
template - note that removed ViewHelper declared it was
a tag based ViewHelper which supports additionalAttributes,
but did not render a tag, which is why all the attributes were
simply ignored and unused.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1214

  1. Claus Due uploaded patch set 1 05/22/17, 15:19

  2. Oliver Klee voted on patch set 1 CR +1 05/22/17, 15:22

  3. TYPO3com voted on patch set 1 V +1 05/22/17, 15:30 Completed build in 10m 53s on Mon, 22 May, 05:30 PM Test Summary: 55887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11702

  4. Christian Kuhn commented on patch set 1 V -1 05/22/17, 16:18

    breaks installing from ter, my example: em -> get extensions -> update d/l "l10nmgr" -> a red popup bla bla dependency appears apply patch, remove half loaded l10nmgr from disk, clear caches d/l "l10nmgr" -> no popup
  5. Claus Due commented on patch set 2 05/22/17, 16:40

    Published edit on patch set 1.
  6. TYPO3com voted on patch set 2 V +1 05/22/17, 16:47 Completed build in 07m 01s on Mon, 22 May, 06:47 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11721

  7. Oliver Klee voted on patch set 2 CR +1 05/23/17, 07:37

  8. Wouter Wolters voted on patch set 2 CR +1 06/01/17, 20:51

  9. Christian Kuhn voted on patch set 2 CR +2 V +2 06/01/17, 20:53

  10. Gerrit merged patch set 2 06/01/17, 20:53

  11. Andreas Kienast commented on patch set 3 06/23/17, 19:04

    Post -2: Those "unused" arguments are used in JS context!
  12. Claus Due commented on patch set 3 06/24/17, 11:12

    Not possible, Andy. The ViewHelper that was removed, was NOT a tag-based VH and did NOT support those "additionalAttributes". The output would have been 100% the same as any non-tag-VH. The attributes would simply never be rendered and so cannot have been used in JS context.
  13. Andreas Kienast commented on patch set 3 06/24/17, 11:46

    Please see https://review.typo3.org/#/c/53318/ and the issue I'm about to solve. Installing incompatible extensions from TER is completely broken now. I found this patch as the cause during bisect.
  14. Claus Due commented on patch set 3 06/24/17, 11:52

    Yeah I see the problem now... the VH I removed also abused the additionalAttributes argument name and had content argument support, which meant the additionalAttributes array got returned from $renderChildrenClosure() if {result} was empty. Let that serve as a reminder to always use clear naming and not use names that have a convention behind them. In this case, that name was *really* misleading.