Review main Merged

52916[BUGFIX] Explicit cast to string for VersionState object

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 05/22/17, 22:01

Commit message

Some DB drivers are picky on their arguments not being
objects. Add an explicit cast to string for a VersionState
object just before it's fed to a query as argument.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Claus Due +1
    • Manuel Selbach +1
  • Verified V +2
    • Christian Kuhn +2
    • Manuel Selbach +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Christian Kuhn uploaded patch set 1 05/22/17, 21:14

  2. TYPO3com voted on patch set 1 V +1 05/22/17, 21:21 Completed build in 07m 22s on Mon, 22 May, 11:21 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11735

  3. Manuel Selbach voted on patch set 1 CR +1 05/22/17, 21:24

  4. Manuel Selbach voted on patch set 1 V +1 05/22/17, 21:25

  5. Claus Due commented on patch set 1 CR -1 05/22/17, 21:39

    PageRepository.php:1667

    If I'm not mistaken, the right way to get a proper instance is to do VersionState::cast($stringEnum) rather than make an instance then cast explicitly.
  6. Christian Kuhn uploaded patch set 2 05/22/17, 21:47

  7. Claus Due commented on patch set 2 CR +1 05/22/17, 21:48

    Belt and suspenders - I like it!
  8. Manuel Selbach voted on patch set 2 CR +1 V +1 05/22/17, 21:50

  9. TYPO3com voted on patch set 2 V +1 05/22/17, 21:54 Completed build in 06m 45s on Mon, 22 May, 11:54 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11736

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 05/22/17, 22:00

  11. Gerrit merged patch set 2 05/22/17, 22:00

  12. Christian Kuhn commented on patch set 3 05/22/17, 22:01

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 8cc8dafefd4c9c6f39d1f29ec5ba228c612aafd1