Review main Merged

52918[TASK] Protect internal properties of PageRepository

Elmar Hinz CR +2 V +2 Normal +69 −3 updated 12/07/17, 15:46

Commit message

Mark the public properties as protected and deprecate them within
PageRepository:

- workspaceCache
- error_getRootLine
- error_getRootLine_failPid

Review

  • Code review CR +2
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1628

Show 23 earlier messages
  1. Elmar Hinz uploaded patch set 1 05/23/17, 14:56

  2. TYPO3com voted on patch set 1 V -1 05/23/17, 15:03 Completed build in 06m 54s on Tue, 23 May, 05:03 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11771

  3. Elmar Hinz uploaded patch set 2 05/23/17, 15:44

  1. TYPO3com voted on patch set 2 V +1 05/23/17, 15:50 Completed build in 06m 37s on Tue, 23 May, 05:50 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11773

  2. Elmar Hinz updated the commit message in patch set 3 05/23/17, 16:00

  3. TYPO3com voted on patch set 3 V +1 05/23/17, 16:08 Completed build in 07m 46s on Tue, 23 May, 06:08 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11775

  4. Elmar Hinz uploaded patch set 4 05/23/17, 16:08

  5. TYPO3com voted on patch set 4 V +1 05/23/17, 16:16 Completed build in 08m 02s on Tue, 23 May, 06:16 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11777

  6. Elmar Hinz uploaded patch set 5 05/23/17, 18:56

  7. TYPO3com voted on patch set 5 V +1 05/23/17, 19:02 Completed build in 06m 18s on Tue, 23 May, 09:02 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11783

  8. Elmar Hinz uploaded patch set 6 05/23/17, 19:27

  9. TYPO3com voted on patch set 6 V +1 05/23/17, 19:33 Completed build in 06m 29s on Tue, 23 May, 09:33 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11784

  10. Elmar Hinz uploaded patch set 7 05/24/17, 06:11

  11. TYPO3com voted on patch set 7 V -1 05/24/17, 06:18 Completed build in 07m 44s on Wed, 24 May, 08:18 AM Test Summary: 82 of 55892 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11792

  12. Elmar Hinz uploaded patch set 8 05/24/17, 06:33

  13. TYPO3com voted on patch set 8 V -1 05/24/17, 06:39 Completed build in 06m 31s on Wed, 24 May, 08:39 AM Test Summary: 82 of 55892 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11793

  14. Benni Mack uploaded patch set 9 11/30/17, 15:14

  15. TYPO3com voted on patch set 9 V +1 11/30/17, 15:24 Completed build in 09m 48s on Thu, 30 Nov, 04:24 PM Test Summary: 57044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17121

  16. Benni Mack updated the commit message in patch set 10 11/30/17, 20:32

  17. TYPO3com voted on patch set 10 V +1 11/30/17, 20:42 Completed build in 09m 57s on Thu, 30 Nov, 09:42 PM Test Summary: 57048 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17137

  18. Benni Mack uploaded patch set 11 12/07/17, 15:09

  19. TYPO3com voted on patch set 11 V +1 12/07/17, 15:20 Completed build in 10m 17s on Thu, 7 Dec, 04:20 PM Test Summary: 57039 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17340

  20. Benni Mack voted on patch set 11 CR +1 V +1 12/07/17, 15:30

  21. Susi Moog commented on patch set 12 12/07/17, 15:36

    Published edit on patch set 11.
  22. Susi Moog voted on patch set 12 CR +1 V +1 12/07/17, 15:36

  23. TYPO3com voted on patch set 12 V +1 12/07/17, 15:46 Completed build in 09m 50s on Thu, 7 Dec, 04:46 PM Test Summary: 57039 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17348

  24. Benni Mack voted on patch set 12 CR +2 V +2 12/07/17, 15:46

  25. Gerrit merged patch set 12 12/07/17, 15:46