Review main Merged

52924[CLEANUP] Remove unused parameter in workspaces hook implementation

Georg Ringer CR +2 V +2 Easy +1 −2 updated 05/28/17, 18:33

Commit message

Remove the last parameter of method makeEditForm_accessCheck
in BackendUtilityHook as it is unused.

Review

  • Code review CR +2
    • Markus Klein +2
    • Oliver Klee +1
    • Mona Muzaffar +1
  • Verified V +2
    • Markus Klein +2
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2025

  1. Georg Ringer uploaded patch set 1 05/24/17, 05:06

  2. TYPO3com voted on patch set 1 V +1 05/24/17, 05:13 Completed build in 06m 39s on Wed, 24 May, 07:13 AM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11789

  3. Kevin Ditscheid voted on patch set 1 CR +1 05/24/17, 07:50

  4. Oliver Klee voted on patch set 1 CR +1 05/24/17, 07:59

  5. Markus Klein commented on patch set 1 CR -1 05/26/17, 09:36

    BackendUtilityHook.php:71

    this is unused,, right? So just remove this!
  6. Oliver Klee commented on patch set 1 05/26/17, 10:17

    BackendUtilityHook.php:71 Reply

    Then this would be (non-breaking) API change. Do we need to deprecate this property first?
  7. Markus Klein commented on patch set 1 05/26/17, 10:40

    BackendUtilityHook.php:71 Reply

    API change?? This is a hook implementation of workspaces for a core functionality. This is no API. Moreover, why deprecating something which does not have functionality?
  8. Oliver Klee commented on patch set 1 05/26/17, 11:55

    BackendUtilityHook.php:71 Reply

    The point of the deprecation is that users that still provide the second argument then get a deprecation warning and can adjust their code. (I would be fine with removing it directly, too.)
  9. Markus Klein commented on patch set 1 05/26/17, 16:32

    BackendUtilityHook.php:71 Reply

    Again, this is no API but a hook implementation. The second parameter is always provided by the core when calling this function. If anyone really really used this method directly, a proper IDE will till you anyway that there is a superfluous parameter now.
  10. Markus Klein commented on patch set 2 05/26/17, 16:33

    Published edit on patch set 1.
  11. Markus Klein updated the commit message in patch set 3 05/26/17, 16:34

  12. Markus Klein updated the commit message in patch set 4 05/26/17, 16:35

  13. TYPO3com voted on patch set 2 V +1 05/26/17, 16:40 Completed build in 07m 16s on Fri, 26 May, 06:40 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11834

  14. TYPO3com voted on patch set 3 V +1 05/26/17, 16:43 Completed build in 09m 12s on Fri, 26 May, 06:43 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11835

  15. TYPO3com voted on patch set 4 V +1 05/26/17, 16:46 Completed build in 10m 24s on Fri, 26 May, 06:46 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11836

  16. Oliver Klee voted on patch set 4 CR +1 05/26/17, 17:07

  17. Wouter Wolters voted on patch set 4 CR +1 V +1 05/27/17, 09:20

  18. Markus Klein updated the commit message in patch set 5 05/27/17, 09:38

  19. Markus Klein commented on patch set 5 05/27/17, 09:38

    one more typo fixed in commit msg
  20. Markus Klein voted on patch set 5 CR +1 V +1 05/27/17, 09:39

  21. TYPO3com voted on patch set 5 V +1 05/27/17, 09:45 Completed build in 06m 21s on Sat, 27 May, 11:45 AM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11844

  22. Oliver Klee voted on patch set 5 CR +1 05/27/17, 14:35

  23. Mona Muzaffar voted on patch set 5 CR +1 V +1 05/28/17, 17:57

  24. Markus Klein voted on patch set 5 CR +2 V +2 05/28/17, 18:33

  25. Gerrit merged patch set 5 05/28/17, 18:33