52924[CLEANUP] Remove unused parameter in workspaces hook implementation
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Oliver Klee +1
- Mona Muzaffar +1
-
Verified V +2
- Markus Klein +2
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2025
-
Georg Ringer uploaded patch set 1 05/24/17, 05:06
-
TYPO3com voted on patch set 1 V +1 05/24/17, 05:13 Completed build in 06m 39s on Wed, 24 May, 07:13 AM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11789
-
Kevin Ditscheid voted on patch set 1 CR +1 05/24/17, 07:50
-
Oliver Klee voted on patch set 1 CR +1 05/24/17, 07:59
-
Markus Klein commented on patch set 1 CR -1 05/26/17, 09:36
-
Oliver Klee commented on patch set 1 05/26/17, 10:17
BackendUtilityHook.php:71ReplyThen this would be (non-breaking) API change. Do we need to deprecate this property first? -
Markus Klein commented on patch set 1 05/26/17, 10:40
BackendUtilityHook.php:71ReplyAPI change?? This is a hook implementation of workspaces for a core functionality. This is no API. Moreover, why deprecating something which does not have functionality? -
Oliver Klee commented on patch set 1 05/26/17, 11:55
BackendUtilityHook.php:71ReplyThe point of the deprecation is that users that still provide the second argument then get a deprecation warning and can adjust their code. (I would be fine with removing it directly, too.) -
Markus Klein commented on patch set 1 05/26/17, 16:32
BackendUtilityHook.php:71ReplyAgain, this is no API but a hook implementation. The second parameter is always provided by the core when calling this function. If anyone really really used this method directly, a proper IDE will till you anyway that there is a superfluous parameter now. -
Markus Klein commented on patch set 2 05/26/17, 16:33
Published edit on patch set 1. -
Markus Klein updated the commit message in patch set 3 05/26/17, 16:34
-
Markus Klein updated the commit message in patch set 4 05/26/17, 16:35
-
TYPO3com voted on patch set 2 V +1 05/26/17, 16:40 Completed build in 07m 16s on Fri, 26 May, 06:40 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11834
-
TYPO3com voted on patch set 3 V +1 05/26/17, 16:43 Completed build in 09m 12s on Fri, 26 May, 06:43 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11835
-
TYPO3com voted on patch set 4 V +1 05/26/17, 16:46 Completed build in 10m 24s on Fri, 26 May, 06:46 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11836
-
Oliver Klee voted on patch set 4 CR +1 05/26/17, 17:07
-
Wouter Wolters voted on patch set 4 CR +1 V +1 05/27/17, 09:20
-
Markus Klein updated the commit message in patch set 5 05/27/17, 09:38
-
Markus Klein commented on patch set 5 05/27/17, 09:38
one more typo fixed in commit msg -
Markus Klein voted on patch set 5 CR +1 V +1 05/27/17, 09:39
-
TYPO3com voted on patch set 5 V +1 05/27/17, 09:45 Completed build in 06m 21s on Sat, 27 May, 11:45 AM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11844
-
Oliver Klee voted on patch set 5 CR +1 05/27/17, 14:35
-
Mona Muzaffar voted on patch set 5 CR +1 V +1 05/28/17, 17:57
-
Markus Klein voted on patch set 5 CR +2 V +2 05/28/17, 18:33
-
Gerrit merged patch set 5 05/28/17, 18:33
BackendUtilityHook.php:71