Review main Merged

52926[TASK] Remove FormatViewHelper of EXT:cshmanual

Georg Ringer CR +2 V +2 Normal +1 −68 updated 06/01/17, 17:42

Commit message

Instead of using a custom viewhelper in the EXT:cshmanual use the
ViewHelpers of fluid and chain those.

Review

  • Code review CR +2
    • Susi Moog +2
    • Joerg Kummer +1
    • Oliver Klee +1
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 910

  1. Georg Ringer uploaded patch set 1 05/24/17, 06:08

  2. TYPO3com voted on patch set 1 V +1 05/24/17, 06:16 Completed build in 08m 04s on Wed, 24 May, 08:16 AM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11791

  3. Joerg Kummer voted on patch set 1 CR +1 05/24/17, 06:36

  4. Oliver Klee voted on patch set 1 CR +1 05/24/17, 08:00

  5. Benni Mack voted on patch set 1 CR +1 V +1 05/25/17, 05:03

  6. Wouter Wolters voted on patch set 1 CR +1 05/25/17, 12:40

  7. Markus Klein commented on patch set 1 05/26/17, 09:33

    no empty lines in the metadata block! (gerrit does not like that too much)

    Manual.html:11

    trim is missing now. is that of importance?
  8. Benni Mack commented on patch set 1 05/28/17, 19:38

    Manual.html:11 Reply

    I browsed through most of the output in BE and it looked ok to me.
  9. Susi Moog voted on patch set 1 CR +2 V +2 06/01/17, 17:42

  10. Gerrit merged patch set 1 06/01/17, 17:42