Review main Abandoned

52930[TASK] Check igbinary PHP extension version in Install Tool

Christian Weiske CR 0 V 0 Easy +39 −0 updated 09/22/17, 12:44

Commit message

igbinary 1.2.1 on Ubuntu 16.04 has a subtle bug with PHP 7 that breaks
the extbase reflection cache. This was fixed with igbinary 2.0.0.

This commit adds a check in the install tool that warns about that.

See https://bugs.launchpad.net/ubuntu/+source/php-igbinary/+bug/1651031
and https://github.com/igbinary/igbinary/issues/114

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1013

  1. Christian Weiske uploaded patch set 1 05/24/17, 08:25

  2. TYPO3com voted on patch set 1 V -1 05/24/17, 08:33 Completed build in 08m 09s on Wed, 24 May, 10:33 AM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11799

  3. Christian Weiske uploaded patch set 2 05/24/17, 08:36

  4. TYPO3com voted on patch set 2 V +1 05/24/17, 08:43 Completed build in 06m 49s on Wed, 24 May, 10:43 AM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11800

  5. Mathias Brodala commented on patch set 2 05/24/17, 11:07

    Check.php:1152

    For everyone reading this: yes this is unnecessary on TYPO3 v8 and master but simplifies the backport to v7.
  6. Mathias Brodala updated the commit message in patch set 3 05/24/17, 11:57

  7. TYPO3com voted on patch set 3 V +1 05/24/17, 12:03 Completed build in 06m 34s on Wed, 24 May, 02:03 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11806

  8. Stefan Neufeind voted on patch set 3 CR +1 07/06/17, 18:32

  9. Tymoteusz Motylewski commented on patch set 2 07/08/17, 15:01

    Do we need to add it to master and v8? I thought igbinary was removed in 8
  10. Stefan Neufeind commented on patch set 3 CR -1 07/08/17, 15:11

    You are right. It's not in 8 or master anymore. Review for the removal was: https://review.typo3.org/47157 Only parts refering to igbinary are under vendor/doctrine/cache. So it's not part of our source in any way. Abandon I guess?
  11. Tymoteusz Motylewski commented on patch set 3 07/08/17, 16:23

    for v7 it might be quite valid. Especially because igbinary is used if detected and there is no way to disable it. So any issue with igbinary is hard to work around.
  12. Christian Weiske abandoned the change 08/18/17, 07:32

    igbinary has been removed in https://review.typo3.org/47157
  13. Michael Stucki commented on patch set 3 09/22/17, 12:44

    See also #54209 which ports the fix from TYPO3 8 to version 7.