52936[BUGFIX] Raise required PCRE version
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
-
Verified V +2
- Christian Kuhn +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1314
-
Stephan Großberndt uploaded patch set 1 05/24/17, 14:12
-
TYPO3com voted on patch set 1 V +1 05/24/17, 14:20 Completed build in 07m 16s on Wed, 24 May, 04:20 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11812
-
Oliver Klee voted on patch set 1 CR +1 05/24/17, 16:07
-
Benni Mack commented on patch set 1 05/25/17, 04:59
Hey Stephan, is there a way to write a test with PSR < 8.38 to see when it segfaults? -
Stephan Großberndt commented on patch set 1 05/29/17, 20:28
I'll try to find it. We had that problem a while ago too with php 5.6 - that was when we added this check in the first place -
Stephan Großberndt commented on patch set 1 05/30/17, 11:54
-
Stephan Großberndt commented on patch set 1 05/30/17, 12:24
I had a crash now in vendor/doctrine/dbal/lib/Doctrine/DBAL/SQLParserUtils.php in function getUnquotedStatementFragments($statement) but in general this may happen in any preg_* statement as it seems. -
Stephan Großberndt commented on patch set 1 05/30/17, 12:29
https://gist.github.com/sgrossberndt/de0e93ca7524894088ab84216b6e7f79 This is all the information I can share now. If you need anything else, mention it. -
Stephan Großberndt commented on patch set 1 05/30/17, 12:32
-
Stephan Großberndt commented on patch set 1 05/30/17, 12:33
-
Georg Ringer voted on patch set 1 CR +1 V +1 06/01/17, 11:54
-
Christian Kuhn voted on patch set 1 CR +2 V +2 06/02/17, 10:09
-
Gerrit merged patch set 1 06/02/17, 10:09
-
Christian Kuhn commented on patch set 2 06/02/17, 10:09
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 46e36bcd7499e815cc5af304f931525c336b4923