Review main Merged

52936[BUGFIX] Raise required PCRE version

Stephan Großberndt CR +2 V +2 Easy +4 −4 updated 06/02/17, 10:09

Commit message

Warn about an outdated PCRE version which is not compatible to PHP 7.0
in the Install Tool to make aware of possible PHP crashes in the TYPO3
backend.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1314

  1. Stephan Großberndt uploaded patch set 1 05/24/17, 14:12

  2. TYPO3com voted on patch set 1 V +1 05/24/17, 14:20 Completed build in 07m 16s on Wed, 24 May, 04:20 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11812

  3. Oliver Klee voted on patch set 1 CR +1 05/24/17, 16:07

  4. Benni Mack commented on patch set 1 05/25/17, 04:59

    Hey Stephan, is there a way to write a test with PSR < 8.38 to see when it segfaults?
  5. Stephan Großberndt commented on patch set 1 05/29/17, 20:28

    I'll try to find it. We had that problem a while ago too with php 5.6 - that was when we added this check in the first place
  6. Stephan Großberndt commented on patch set 1 05/30/17, 11:54

  7. Stephan Großberndt commented on patch set 1 05/30/17, 12:24

    I had a crash now in vendor/doctrine/dbal/lib/Doctrine/DBAL/SQLParserUtils.php in function getUnquotedStatementFragments($statement) but in general this may happen in any preg_* statement as it seems.
  8. Stephan Großberndt commented on patch set 1 05/30/17, 12:29

    https://gist.github.com/sgrossberndt/de0e93ca7524894088ab84216b6e7f79 This is all the information I can share now. If you need anything else, mention it.
  9. Stephan Großberndt commented on patch set 1 05/30/17, 12:32

  10. Georg Ringer voted on patch set 1 CR +1 V +1 06/01/17, 11:54

  11. Christian Kuhn voted on patch set 1 CR +2 V +2 06/02/17, 10:09

  12. Gerrit merged patch set 1 06/02/17, 10:09

  13. Christian Kuhn commented on patch set 2 06/02/17, 10:09

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 46e36bcd7499e815cc5af304f931525c336b4923