Review main Merged

52937[TASK] Add type hints and fix PHPDoc in extbase DataMapFactory

Stephan Großberndt CR +2 V +2 Easy +7 −7 updated 06/02/17, 14:12

Commit message

While this is technically a breaking change it only affects internal API.

Review

  • Code review CR +2
    • Susi Moog +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Susi Moog +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Stephan Großberndt uploaded patch set 1 05/24/17, 14:15

  2. Mathias Brodala updated the commit message in patch set 2 05/24/17, 14:17

  3. TYPO3com voted on patch set 1 V +1 05/24/17, 14:22 Completed build in 07m 44s on Wed, 24 May, 04:22 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11813

  4. TYPO3com voted on patch set 2 V +1 05/24/17, 14:25 Completed build in 08m 23s on Wed, 24 May, 04:25 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11814

  5. Stephan Großberndt commented on patch set 2 05/24/17, 14:29

    DataMapFactory.php:324

    Type hinting here using array $columnConfiguration = null is not possible as there is a third parameter $propertyMetaData Type hinting here using array $columnConfiguration is not possible as $columnConfiguration may be NULL
  6. Oliver Klee voted on patch set 2 CR +1 05/24/17, 16:05

  7. Oliver Klee commented on patch set 2 05/24/17, 16:05

    Thanks! <3
  8. Christian Kuhn voted on patch set 2 CR +1 V +1 06/02/17, 10:22

  9. Wouter Wolters voted on patch set 2 CR +1 06/02/17, 10:23

  10. Susi Moog voted on patch set 2 CR +2 V +2 06/02/17, 14:12

  11. Gerrit merged patch set 2 06/02/17, 14:12

  12. Susi Moog commented on patch set 3 06/02/17, 14:12

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d24b99b7d3c252b327273528189c8e0e4cfcec0f