Review main Merged

52938[BUGFIX] Make TemplatePaths->fillDefaultsByPackageName sort paths

Claus Due CR +2 V +2 Normal +101 −35 updated 06/22/17, 15:11

Commit message

Due to the sequence of methods being called from this method,
it is necessary to sort TS-configured paths right when they are
resolved instead of passing the unsorted array further down.

Patch also sorts methods protected below public; true diff is
one line. Toggle this line between before/after and run the test
to see the problem demonstrated.

See issue description for a more detailed reasoning.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Sommer +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Sommer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1113

  1. Claus Due uploaded patch set 1 05/24/17, 15:41

  2. TYPO3com voted on patch set 1 V +1 05/24/17, 15:48 Completed build in 06m 34s on Wed, 24 May, 05:48 PM Test Summary: 55895 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11816

  3. Oliver Klee commented on patch set 1 05/24/17, 16:07

    TemplatePaths.php:214

    Shorter: if (!is_array…) return… (as a guard clause)
  4. Claus Due commented on patch set 2 05/28/17, 17:42

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 05/28/17, 17:51 Completed build in 08m 56s on Sun, 28 May, 07:51 PM Test Summary: 55895 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11849

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 06/04/17, 09:34

  7. Markus Sommer voted on patch set 2 CR +1 V +1 06/04/17, 09:37

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 06/04/17, 09:38

  9. Gerrit merged patch set 2 06/04/17, 09:38

  10. Christian Kuhn commented on patch set 3 06/04/17, 09:38

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 90ada1d7375869acc0f4cd1aece39bc7f8fd5745
  11. Markus Klein commented on patch set 3 06/22/17, 14:49

    TemplatePaths.php:113

    https://forge.typo3.org/issues/81677 This one misses the check for FE now. you will merge the FE paths too if mode is BE, but not TS config is set
  12. Claus Due commented on patch set 3 06/22/17, 15:07

    TemplatePaths.php:113 Reply

    You're right, sorry. I forgot to either !$this->isBackendMode() or add $this->isFrontendMode(). The first would be more simple because the only non-BE context is by definition FE, but perhaps the second would be more explicit if someone comes across the code in the future...
  13. Claus Due commented on patch set 3 06/22/17, 15:11