Review main Merged

52970[BUGFIX] Remove disabled button in inline records

Johannes Schlier CR +2 V +2 Easy +6 −4 updated 06/02/17, 11:15

Commit message

If the info icon is disabled it is now removed completely.
Previously the logic for new records was not caught correctly, so that
the case for the enabled icon with a new record was executed.
Disabling the icon should remove it completely,
as a disabled non-clickable icon is not helpful and confusing for editors.
This is now done, and the case for the enabled icon with new records is
also correctly caught.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Windloff +1
    • Markus Sommer +1
  • Verified V +2
    • Christian Kuhn +2
    • Daniel Windloff +1
    • Markus Sommer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1215

  1. Johannes Schlier uploaded patch set 1 05/30/17, 15:27

  2. TYPO3com voted on patch set 1 V +1 05/30/17, 15:34 Completed build in 06m 46s on Tue, 30 May, 05:34 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11892

  3. Daniel Windloff commented on patch set 1 05/31/17, 20:42

    The empty button should still appear in case of a new record with enabled info control.
  4. Johannes Schlier updated the commit message in patch set 2 06/02/17, 10:46

  5. Johannes Schlier uploaded patch set 3 06/02/17, 10:48

  6. Johannes Schlier commented on patch set 3 06/02/17, 10:50

    You are right, that makes sense. I changed the logic to include both cases.
  7. TYPO3com voted on patch set 2 V +1 06/02/17, 10:59 Completed build in 12m 37s on Fri, 2 Jun, 12:59 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12045

  8. Daniel Windloff voted on patch set 3 CR +1 06/02/17, 11:02

  9. TYPO3com voted on patch set 3 V +1 06/02/17, 11:03 Completed build in 14m 09s on Fri, 2 Jun, 01:03 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12046

  10. Christian Kuhn voted on patch set 3 CR +1 V +1 06/02/17, 11:09

  11. Markus Sommer voted on patch set 3 CR +1 V +1 06/02/17, 11:14

  12. Daniel Windloff voted on patch set 3 V +1 06/02/17, 11:14

  13. Christian Kuhn voted on patch set 3 CR +2 V +2 06/02/17, 11:14

  14. Gerrit merged patch set 3 06/02/17, 11:14

  15. Christian Kuhn commented on patch set 4 06/02/17, 11:15

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit e2e3f9c35753807906cb0b87ca1a52a3d44509bb