Review main Merged

52980[TASK] Refactor ext:impexp functional tests

Christian Kuhn CR +2 V +2 Nightmare +1434 −1937 updated 05/31/17, 19:30

Commit message

The ext:impexp functional tests are rather hard to read and
follow. The patch untangles them to make them better maintainable:

* Combine the two different import / export abstract classes into 1 class
* Don't inherit from AbstractDataHandlerActionTestCase anymore
* Give single test cases better file names and do not hide them in sub dirs
* Move all fixtures to Fixtures/ dir
* Use less helper methods to import and test things
* File paths are more straight and with less helper magic

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Mona Muzaffar +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 93

Show 73 more files

Review log 1217

  1. Christian Kuhn uploaded patch set 1 05/31/17, 17:32

  2. TYPO3com voted on patch set 1 V -1 05/31/17, 17:39 Completed build in 07m 13s on Wed, 31 May, 07:39 PM Test Summary: 2 of 55892 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11927

  3. Christian Kuhn uploaded patch set 2 05/31/17, 17:41

  4. TYPO3com voted on patch set 2 V -1 05/31/17, 17:48 Completed build in 06m 22s on Wed, 31 May, 07:48 PM Test Summary: 2 of 55892 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11928

  5. Christian Kuhn uploaded patch set 3 05/31/17, 18:07

  6. Christian Kuhn uploaded patch set 4 05/31/17, 18:11

  7. TYPO3com voted on patch set 3 V +1 05/31/17, 18:14 Completed build in 07m 01s on Wed, 31 May, 08:14 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11929

  8. Oliver Klee commented on patch set 4 05/31/17, 18:18

    This probably is a WIP, right?
  9. TYPO3com voted on patch set 4 V +1 05/31/17, 18:19 Completed build in 07m 40s on Wed, 31 May, 08:19 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11930

  10. Christian Kuhn uploaded patch set 5 05/31/17, 18:34

  11. Christian Kuhn commented on patch set 5 05/31/17, 18:35

    no longer WIP
  12. TYPO3com voted on patch set 5 V +1 05/31/17, 18:40 Completed build in 06m 44s on Wed, 31 May, 08:40 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11931

  13. Anja Leichsenring voted on patch set 5 CR +1 V +1 05/31/17, 18:46

  14. Mona Muzaffar voted on patch set 5 CR +1 V +1 05/31/17, 19:14

  15. Christian Kuhn commented on patch set 5 05/31/17, 19:16

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit bca302256530610771d6e0ed0bdd945c758d6e83
  16. Christian Kuhn voted on patch set 5 CR +2 V +2 05/31/17, 19:30

  17. Gerrit merged patch set 5 05/31/17, 19:30