Review TYPO3_8-7 Merged

52981[TASK] Refactor ext:impexp functional tests

Christian Kuhn CR +2 V +2 Nightmare +1434 −1937 updated 05/31/17, 19:31

Commit message

The ext:impexp functional tests are rather hard to read and
follow. The patch untangles them to make them better maintainable:

* Combine the two different import / export abstract classes into 1 class
* Don't inherit from AbstractDataHandlerActionTestCase anymore
* Give single test cases better file names and do not hide them in sub dirs
* Move all fixtures to Fixtures/ dir
* Use less helper methods to import and test things
* File paths are more straight and with less helper magic

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 93

Show 73 more files

Review log 34

  1. Christian Kuhn commented on patch set 1 05/31/17, 19:16

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 05/31/17, 19:23 Completed build in 06m 15s on Wed, 31 May, 09:23 PM Test Summary: 56777 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-234

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 05/31/17, 19:30

  4. Gerrit merged patch set 1 05/31/17, 19:31