Review main Abandoned

52983[RESEARCH] Encapsulate TemplateService methods

Elmar Hinz CR 0 V 0 Normal +47 −12 updated 12/09/17, 22:28

Commit message

- 14 public methods are accessed from outside from non-tests
- 1 public mehod is accessed from a test only
- 11 public methods are not accessd from outside the class

Summary

- 12 public methods out of 26 can be migrated to protected

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 47

  1. Elmar Hinz uploaded patch set 1 05/31/17, 19:57

  2. TYPO3com voted on patch set 1 V -1 05/31/17, 20:04 Completed build in 07m 06s on Wed, 31 May, 10:04 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11935

  3. Elmar Hinz uploaded patch set 2 06/01/17, 05:20

  4. TYPO3com voted on patch set 2 V +1 06/01/17, 05:27 Completed build in 06m 49s on Thu, 1 Jun, 07:27 AM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11944

  5. Elmar Hinz updated the commit message in patch set 3 06/01/17, 05:31

  6. TYPO3com voted on patch set 3 V +1 06/01/17, 05:38 Completed build in 06m 46s on Thu, 1 Jun, 07:38 AM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11945

  7. Benni Mack abandoned the change 12/09/17, 22:28

    abandoned for now, we already deprecated/remove parts here.