Review main Abandoned Breaking

52988[WIP][!!!][CLEANUP] Protect internals of PageRepository

Elmar Hinz CR 0 V 0 Easy +12 −8 updated 11/30/17, 15:16

Commit message

Set internal methods and properties to protected.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 35

  1. Elmar Hinz uploaded patch set 1 06/01/17, 12:00

  2. TYPO3com voted on patch set 1 V +1 06/01/17, 12:06 Completed build in 06m 27s on Thu, 1 Jun, 02:06 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11951

  3. Elmar Hinz uploaded patch set 2 06/01/17, 13:57

  4. TYPO3com voted on patch set 2 V +1 06/01/17, 14:06 Completed build in 09m 13s on Thu, 1 Jun, 04:06 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11959

  5. Benni Mack abandoned the change 11/30/17, 15:16

    Will abandon this one, as we solve the property protection in the other patch, and deprecate unused methods separately.