53000[FEATURE] Configurable Route Parameters
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Susi Moog +1
-
Verified V +2
- Christian Kuhn +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/backend/Classes/Routing/UriBuilder.php+4 −0
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+8 −2
- typo3/sysext/backend/Resources/Public/JavaScript/LoginRefresh.js+0 −3
- typo3/sysext/backend/Tests/Unit/Routing/UriBuilderTest.phpnew+123 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-81409-Configurable-Route-Parameters.rst1new+37 −0
- typo3/sysext/rsaauth/Configuration/Backend/AjaxRoutes.php+4 −1
- typo3/sysext/rsaauth/Resources/Public/JavaScript/RsaEncryptionModule.js+0 −1
Review log 1829
Show 34 earlier messages
-
Johannes Goslar uploaded patch set 1 06/01/17, 16:26
-
TYPO3com voted on patch set 1 V +1 06/01/17, 16:33 Completed build in 07m 46s on Thu, 1 Jun, 06:33 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11966
-
Oliver Hader commented on patch set 1 CR -1 06/01/17, 16:54
This one needs a RST file to document the AjaxRoutes parameters -
Oliver Hader commented on patch set 1 06/01/17, 17:53
Working on it...
-
Johannes Goslar uploaded patch set 2 06/01/17, 19:16
-
TYPO3com voted on patch set 2 V -1 06/01/17, 19:22 Completed build in 06m 17s on Thu, 1 Jun, 09:22 PM Test Summary: 1 of 55892 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11979
-
TYPO3com voted on patch set 2 V +1 06/01/17, 19:27 Completed build in 17m 13s on Thu, 1 Jun, 09:27 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11979
-
Oliver Hader commented on patch set 2 CR -1 06/01/17, 20:18
Working on it... -
Oliver Hader uploaded patch set 3 06/01/17, 21:06
-
TYPO3com voted on patch set 3 V +1 06/01/17, 21:30 Completed build in 23m 42s on Thu, 1 Jun, 11:30 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11996
-
Susi Moog commented on patch set 3 CR -1 06/02/17, 07:21
optimizing the tests -
Johannes Goslar commented on patch set 3 06/02/17, 07:23
minor typos*defineFeature-81409-Configurable-Route-Parameters.rst:35*Route -
Susi Moog uploaded patch set 4 06/02/17, 08:47
-
Susi Moog uploaded patch set 5 06/02/17, 08:49
-
TYPO3com voted on patch set 4 V -1 06/02/17, 08:54 Completed build in 07m 13s on Fri, 2 Jun, 10:54 AM Test Summary: 10 of 55934 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12015
-
TYPO3com voted on patch set 5 V -1 06/02/17, 08:58 Completed build in 09m 43s on Fri, 2 Jun, 10:58 AM Test Summary: 18 of 55934 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12017
-
Susi Moog uploaded patch set 6 06/02/17, 09:48
-
TYPO3com voted on patch set 6 V -1 06/02/17, 09:55 Completed build in 07m 20s on Fri, 2 Jun, 11:55 AM Test Summary: 22 of 55934 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12026
-
Susi Moog uploaded patch set 7 06/02/17, 09:58
-
TYPO3com voted on patch set 7 V -1 06/02/17, 10:08 Completed build in 10m 29s on Fri, 2 Jun, 12:08 PM Test Summary: 4 of 55934 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12028
-
Susi Moog uploaded patch set 8 06/02/17, 10:44
-
TYPO3com voted on patch set 8 V -1 06/02/17, 10:56 Completed build in 11m 21s on Fri, 2 Jun, 12:56 PM Test Summary: 48 of 55934 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12043
-
Susi Moog uploaded patch set 9 06/02/17, 11:09
-
TYPO3com voted on patch set 9 V -1 06/02/17, 11:16 Completed build in 06m 27s on Fri, 2 Jun, 01:16 PM Test Summary: 992 of 55934 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12049
-
Susi Moog uploaded patch set 10 06/02/17, 11:27
-
Susi Moog commented on patch set 10 CR +1 V +1 06/02/17, 11:29
to sum up my experience: static attributes are hell, singletons are, too and both in combination end up in a war on side-effects... so in the end I gave up and re-pushed patch set 3... -
TYPO3com voted on patch set 10 V +1 06/02/17, 11:34 Completed build in 07m 28s on Fri, 2 Jun, 01:34 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12053
-
Christian Kuhn voted on patch set 10 CR +2 V +2 06/02/17, 11:57
-
Gerrit merged patch set 10 06/02/17, 11:57